Bug #106750 Some clone tests needlessly marked as Linux-only

Description:
Several testcases in the clone suite are marked as Linux-only, which appears to be a needless limitation: remote_dml_recovery, error_archival, local_dml_auto_tune, remote_dml_auto_tune, remote_dml_upgrade.

Removing --source include/linux.inc allows them to pass on macOS as-is.

Perhaps they are meant to be not_windows.inc (some of them already are).

remote_dml_upgrade.test also has conflicting condition in it: it sources include/linux.inc and then goes on to check whether it's running under windows:

let $have_windows = `SELECT CONVERT(@@version_compile_os using latin1) IN ("Win32", "Win64", "Windows")`;

if (!$have_windows) {
  --source include/have_mysqld_safe.inc
  --let inst_monitor = 1
}

How to repeat:
On macOS, remove --source include/linux.inc, and watch tests pass:

[ 16%] clone.remote_dml_recovery                w3  [ pass ]  65839
[ 33%] clone.error_archival                     w5  [ pass ]  75335
[ 50%] clone.local_dml_auto_tune                w4  [ pass ]  293623
[ 66%] clone.remote_dml_auto_tune               w2  [ pass ]  309505
[ 83%] clone.remote_dml_upgrade                 w1  [ pass ]  343238
[100%] shutdown_report                          w0  [ pass ]   

Suggested fix:
Remove --source include/linux.inc

While at that, the slowest tests in the above perhaps should be marked as big tests?

Hello Laurynas,

Thank you for the report and feedback!

regards,
Umesh

Bug 106750 fix for 8.0.30

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: bug106750.patch (application/octet-stream, text), 2.48 KiB.

The patch applies to 8.0.31 too, MTR clone suite passes cleanly.

The patch applies to 8.0.31 too, MTR clone suite passes cleanly.

Applies to 8.0.32 too.

Applies cleanly on 8.0.32 and does not regress MTR

Oops, 8.0.33

Bug 106750 fix updated for 8.4.0

(*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: bug106750-8.4.0.patch (application/octet-stream, text), 2.06 KiB.

The previously submitted patch no longer applies cleanly on 8.4.0. Updated.

My contributed patch applies cleanly on 9.0.0 and passes the tests.

The contributed patch applies on 9.1.0 cleanly and passes the tests.

Posted by developer: Bug status updated to 'Patch pending'