| Bug #106750 | Some clone tests needlessly marked as Linux-only | ||
|---|---|---|---|
| Submitted: | 16 Mar 2022 15:44 | Modified: | 22 Oct 2024 8:24 |
| Reporter: | Laurynas Biveinis (OCA) | Email Updates: | |
| Status: | Verified | Impact on me: | |
| Category: | MySQL Server: Clone Plugin | Severity: | S7 (Test Cases) |
| Version: | 8.0.28-8.0.32 | OS: | Any |
| Assigned to: | CPU Architecture: | Any | |
| Tags: | Clone, Contribution, mtr | ||
[17 Mar 2022 5:42]
MySQL Verification Team
Hello Laurynas, Thank you for the report and feedback! regards, Umesh
[6 Sep 2022 14:49]
Laurynas Biveinis
Bug 106750 fix for 8.0.30 (*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.
Contribution: bug106750.patch (application/octet-stream, text), 2.48 KiB.
[12 Oct 2022 12:11]
Laurynas Biveinis
The patch applies to 8.0.31 too, MTR clone suite passes cleanly.
[12 Oct 2022 12:14]
Laurynas Biveinis
The patch applies to 8.0.31 too, MTR clone suite passes cleanly.
[17 Jan 2023 14:02]
Laurynas Biveinis
Applies to 8.0.32 too.
[20 Apr 2023 7:36]
Laurynas Biveinis
Applies cleanly on 8.0.32 and does not regress MTR
[20 Apr 2023 7:36]
Laurynas Biveinis
Oops, 8.0.33
[27 May 2024 11:10]
Laurynas Biveinis
Bug 106750 fix updated for 8.4.0 (*) I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.
Contribution: bug106750-8.4.0.patch (application/octet-stream, text), 2.06 KiB.
[27 May 2024 11:11]
Laurynas Biveinis
The previously submitted patch no longer applies cleanly on 8.4.0. Updated.
[9 Jul 2024 12:57]
Laurynas Biveinis
My contributed patch applies cleanly on 9.0.0 and passes the tests.
[22 Oct 2024 8:24]
Laurynas Biveinis
The contributed patch applies on 9.1.0 cleanly and passes the tests.
Description: Several testcases in the clone suite are marked as Linux-only, which appears to be a needless limitation: remote_dml_recovery, error_archival, local_dml_auto_tune, remote_dml_auto_tune, remote_dml_upgrade. Removing --source include/linux.inc allows them to pass on macOS as-is. Perhaps they are meant to be not_windows.inc (some of them already are). remote_dml_upgrade.test also has conflicting condition in it: it sources include/linux.inc and then goes on to check whether it's running under windows: let $have_windows = `SELECT CONVERT(@@version_compile_os using latin1) IN ("Win32", "Win64", "Windows")`; if (!$have_windows) { --source include/have_mysqld_safe.inc --let inst_monitor = 1 } How to repeat: On macOS, remove --source include/linux.inc, and watch tests pass: [ 16%] clone.remote_dml_recovery w3 [ pass ] 65839 [ 33%] clone.error_archival w5 [ pass ] 75335 [ 50%] clone.local_dml_auto_tune w4 [ pass ] 293623 [ 66%] clone.remote_dml_auto_tune w2 [ pass ] 309505 [ 83%] clone.remote_dml_upgrade w1 [ pass ] 343238 [100%] shutdown_report w0 [ pass ] Suggested fix: Remove --source include/linux.inc While at that, the slowest tests in the above perhaps should be marked as big tests?