MySQL Bugs: #48048: Deprecated constructs need removal in Betony

Bug #48048	Deprecated constructs need removal in Betony
Submitted:	14 Oct 2009 16:37	Modified:	7 Mar 2010 0:03
Reporter:	Paul DuBois	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: General	Severity:	S3 (Non-critical)
Version:	5.5.0	OS:	Any
Assigned to:	Luis Soares	CPU Architecture:	Any

Description:
I am filing a bug report to make this issue explicit and so that it can be tracked.

In 5.2.5, we made this change to remove a bunch of stuff that had
been declared deprecated:

----------
* Incompatible Change: The obsolete constructs in the following
 table have been removed. Use the equivalents shown in the
 table's second column instead. Existing applications that
 depend on the obsolete constructs should be converted to make
 use of the current equivalents as soon as possible.

Obsolete:                         Current:

@@table_type                      @@storage_engine

@@log_bin_trust_routine_creators  @@log_bin_trust_function_creators

TIMESTAMP(N)                      See Section 11.6, "Date and Time Functions."

TYPE=                             ENGINE=

BACKUP TABLE                      mysqldump or mysqlhotcopy

RESTORE TABLE,                    mysqldump or mysql
LOAD TABLE FROM MASTER

SHOW TABLE TYPES                  SHOW [STORAGE] ENGINES

SHOW INNODB STATUS                SHOW ENGINE INNODB STATUS

SHOW MUTEX STATUS                 SHOW ENGINE INNODB MUTEX

--master-xxx options to set       CHANGE MASTER TO
replication parameters:
--master-host,
--master-user,
--master-password,
--master-port,
--master-connect-retry,
--master-ssl,
--master-ssl-ca,
--master-ssl-capath,
--master-ssl-cert,
--master-ssl-cipher,
--master-ssl-key
----------

These obsolete constructs were also removed in 6.0. However,
they were *not* removed in 5.4. It would be good to get them
removed in 5.5, preferably as early as 5.5.0 so that the obsolete
stuff need not be mentioned in the 5.5 manual at all except in
the changelog.

Note that a related item has already been backported from 6.0
and pushed to 5.5.0: Bug#34818: --default-table-type option should be removed

One thing to consider when removing the obsolete constructs
is that older series have warning messages that refer to 6.0.
Perhaps those should be updated to refer to 5.5 instead.
Example:

mysql> create table t (i int) type =myisam;
Query OK, 0 rows affected, 1 warning (0.15 sec)

mysql> show warnings;
+---------+------+-----------------------------------------------------------------------------------------------------------------------------+
| Level   | Code | Message
|
+---------+------+-----------------------------------------------------------------------------------------------------------------------------+
| Warning | 1287 | The syntax 'TYPE=storage_engine' is deprecated and will be
removed in MySQL 6.0. Please use 'ENGINE=storage_engine' instead |
+---------+------+-----------------------------------------------------------------------------------------------------------------------------+
1 row in set (0.00 sec)

See also Bug#44676.

How to repeat:
See above

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/89303

backport approved

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/90030

3140 Luis Soares	2009-11-11
      BUG#48048: Deprecated constructs need removal in Betony
      
      Removed test case that was left without significance after
      backporting the deprecated constructs from 6.0 codebase.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/90342

3142 Luis Soares	2009-11-13
      BUG#48048: Deprecated constructs need removal in Betony
      
      Post-push fix: Reverting change in Makefile.am which was
      causing windows not to build client/.

A patch for this bug has been committed. After review, it may
be pushed to the relevant source trees for release in the next
version. You can access the patch from:

  http://lists.mysql.com/commits/90499

3143 Luis Soares	2009-11-16
      BUG#48048: Deprecated constructs need removal in Betony
      
      Post-push fix: Removed MTRv1 arguments according to the
      original patch. Although there is a version check, the patch
      was pushed to a 5.1 GA staging tree, while the version check 
      considers version 5.2. This makes the deprecated parameters 
      to be used, despite the fact that they are not valid anymore.
      
      Part of MTRv1 is currently used in RQG semisync test, and this
      was causing the test to fail on slave startup.
      
      It should be safe to uncomment when merging up to celosia.

Pushed into 6.0.14-alpha (revid:aelkin@mysql.com-20091202145207-zjr6kdpwm5z5jj2z) (version source revid:aelkin@mysql.com-20091202145207-zjr6kdpwm5z5jj2z) (merge vers: 6.0.14-alpha) (pib:13)

Pushed into 5.6.0-beta (revid:aelkin@mysql.com-20091201190718-ls6a6i82bs4vovf9) (version source revid:aelkin@mysql.com-20091201190718-ls6a6i82bs4vovf9) (merge vers: 5.6.0-beta) (pib:13)

Noted in 5.6.0 changelog.

Already fixed in 6.0.x.

Pushed into 5.5.3-m3 (revid:alik@sun.com-20100306103849-hha31z2enhh7jwt3) (version source revid:vvaintroub@mysql.com-20091202211633-8reso8l6h11gw9ot) (merge vers: 5.6.0-beta) (pib:16)

Moved 5.6.0 changelog entry to 5.5.3.