From 0cfc4199c1742dc30beb209f21a82e739680f085 Mon Sep 17 00:00:00 2001 From: Alexey Kopytov Date: Fri, 25 Aug 2017 14:35:44 +0300 Subject: [PATCH] Bug #87543: dd_sdi-t.cc assumes 'char' to be signed Declare 'x' as a signed char explicitly in the CharPromotion test. --- unittest/gunit/dd_sdi-t.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/unittest/gunit/dd_sdi-t.cc b/unittest/gunit/dd_sdi-t.cc index 941ed20bf6f..0bce6fe1c19 100644 --- a/unittest/gunit/dd_sdi-t.cc +++ b/unittest/gunit/dd_sdi-t.cc @@ -515,7 +515,7 @@ TEST(SdiTest, Serialization_perf) TEST(SdiTest, CharPromotion) { - char x= 127; + signed char x= 127; unsigned char ux= x; EXPECT_EQ(127u, ux); @@ -526,7 +526,7 @@ TEST(SdiTest, CharPromotion) EXPECT_EQ(127u, usx); unsigned char tmp= 0xe0; - x= static_cast(tmp); + x= static_cast(tmp); EXPECT_EQ(-32,x); ux= x;