From ad8f6382a8ee924f78bb226a1f869e0316093ff4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Dani=C3=ABl=20van=20Eeden?= Date: Tue, 4 Feb 2025 12:07:57 +0100 Subject: [PATCH] protocol_classic: clarify param type and flag --- sql/protocol_classic.cc | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/sql/protocol_classic.cc b/sql/protocol_classic.cc index 5a9eb6d4b432..24e69dd0c716 100644 --- a/sql/protocol_classic.cc +++ b/sql/protocol_classic.cc @@ -1504,9 +1504,12 @@ int Protocol_classic::read_packet() { new_params_bind_flag Always 1. Malformed packet error if not 1 if new_params_bind_flag, for each parameter { - @ref a_protocol_type_int2 "int<2>" - param_type_and_flag - Parameter type (2 bytes). The MSB is reserved for unsigned flag + @ref a_protocol_type_int1 "int<1>" + parameter_type + Parameter type (1 bytes). See ::enum_field_type + @ref a_protocol_type_int1 "int<1>" + parameter_flags + Parameter flags (1 bytes). Set to 128 if unsigned. @ref sect_protocol_basic_dt_string_le "string<lenenc>" parameter name String @@ -2113,9 +2116,12 @@ int Protocol_classic::read_packet() { new_params_bind_flag Flag if parameters must be re-bound if new_params_bind_flag, for each parameter { - @ref a_protocol_type_int2 "int<2>" + @ref a_protocol_type_int1 "int<1>" parameter_type Type of the parameter value. See ::enum_field_type + @ref a_protocol_type_int1 "int<1>" + parameter_flags + Parameter flags (1 bytes). Set to 128 if unsigned. if ::CLIENT_QUERY_ATTRIBUTES is on { @ref sect_protocol_basic_dt_string_le "string<lenenc>" parameter_name