From 5eda16d0fa9721b955c21a2ca3145dad05b24684 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Henning=20P=C3=B6ttker?= Date: Sat, 6 Jan 2024 23:27:33 +0100 Subject: [PATCH] Replace StringBuffer with StringBuilder in ValueEncoders --- .../java/com/mysql/cj/protocol/a/InstantValueEncoder.java | 2 +- .../com/mysql/cj/protocol/a/OffsetDateTimeValueEncoder.java | 2 +- .../java/com/mysql/cj/protocol/a/SqlTimeValueEncoder.java | 2 +- .../com/mysql/cj/protocol/a/SqlTimestampValueEncoder.java | 4 ++-- .../com/mysql/cj/protocol/a/UtilCalendarValueEncoder.java | 2 +- .../java/com/mysql/cj/protocol/a/UtilDateValueEncoder.java | 4 ++-- .../com/mysql/cj/protocol/a/ZonedDateTimeValueEncoder.java | 2 +- 7 files changed, 9 insertions(+), 9 deletions(-) diff --git a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/InstantValueEncoder.java b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/InstantValueEncoder.java index 8c85a9cd8..327e32ab4 100644 --- a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/InstantValueEncoder.java +++ b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/InstantValueEncoder.java @@ -76,7 +76,7 @@ public String getString(BindValue binding) { .atZoneSameInstant(this.serverSession.getDefaultTimeZone().toZoneId()).toLocalDateTime()), binding.getField(), binding.keepOrigNanos()); - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append(TimeUtil.getSimpleDateFormat(null, "''yyyy-MM-dd HH:mm:ss", binding.getMysqlType() == MysqlType.TIMESTAMP && this.preserveInstants.getValue() ? this.serverSession.getSessionTimeZone() diff --git a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/OffsetDateTimeValueEncoder.java b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/OffsetDateTimeValueEncoder.java index cacf84e4c..f2e07ba7e 100644 --- a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/OffsetDateTimeValueEncoder.java +++ b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/OffsetDateTimeValueEncoder.java @@ -75,7 +75,7 @@ public String getString(BindValue binding) { ((OffsetDateTime) binding.getValue()).atZoneSameInstant(this.serverSession.getDefaultTimeZone().toZoneId()).toLocalDateTime()), binding.getField(), binding.keepOrigNanos()); - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append(TimeUtil.getSimpleDateFormat(null, "''yyyy-MM-dd HH:mm:ss", binding.getMysqlType() == MysqlType.TIMESTAMP && this.preserveInstants.getValue() ? this.serverSession.getSessionTimeZone() diff --git a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/SqlTimeValueEncoder.java b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/SqlTimeValueEncoder.java index 4cd02d091..c8893538c 100644 --- a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/SqlTimeValueEncoder.java +++ b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/SqlTimeValueEncoder.java @@ -87,7 +87,7 @@ public String getString(BindValue binding) { ts = TimeUtil.truncateFractionalSeconds(ts); } - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append(binding.getCalendar() != null ? TimeUtil.getSimpleDateFormat("''yyyy-MM-dd HH:mm:ss", binding.getCalendar()).format(x) : TimeUtil.getSimpleDateFormat(null, "''yyyy-MM-dd HH:mm:ss", this.serverSession.getDefaultTimeZone()).format(x)); if (this.serverSession.getCapabilities().serverSupportsFracSecs() && ts.getNanos() > 0) { diff --git a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/SqlTimestampValueEncoder.java b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/SqlTimestampValueEncoder.java index e761bf139..4f4b3da86 100644 --- a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/SqlTimestampValueEncoder.java +++ b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/SqlTimestampValueEncoder.java @@ -75,7 +75,7 @@ public String getString(BindValue binding) { case TEXT: case MEDIUMTEXT: case LONGTEXT: - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (binding.getCalendar() != null) { buf.append(TimeUtil.getSimpleDateFormat("''yyyy-MM-dd HH:mm:ss", binding.getCalendar()).format(x)); @@ -157,7 +157,7 @@ public void encodeAsBinary(Message msg, BindValue binding) { case TEXT: case MEDIUMTEXT: case LONGTEXT: - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (binding.getCalendar() != null) { buf.append(TimeUtil.getSimpleDateFormat("yyyy-MM-dd HH:mm:ss", binding.getCalendar()).format(x)); diff --git a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/UtilCalendarValueEncoder.java b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/UtilCalendarValueEncoder.java index cef61bbb5..56cb34f90 100644 --- a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/UtilCalendarValueEncoder.java +++ b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/UtilCalendarValueEncoder.java @@ -65,7 +65,7 @@ public String getString(BindValue binding) { case TIMESTAMP: Timestamp ts = adjustTimestamp(new java.sql.Timestamp(((Calendar) binding.getValue()).getTimeInMillis()), binding.getField(), binding.keepOrigNanos()); - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (binding.getCalendar() != null) { buf.append(TimeUtil.getSimpleDateFormat("''yyyy-MM-dd HH:mm:ss", binding.getCalendar()).format(x)); } else { diff --git a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/UtilDateValueEncoder.java b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/UtilDateValueEncoder.java index c6f0e808c..8cda81d3d 100644 --- a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/UtilDateValueEncoder.java +++ b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/UtilDateValueEncoder.java @@ -77,7 +77,7 @@ public String getString(BindValue binding) { case TEXT: case MEDIUMTEXT: case LONGTEXT: - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (binding.getCalendar() != null) { buf.append(TimeUtil.getSimpleDateFormat("''yyyy-MM-dd HH:mm:ss", binding.getCalendar()).format(x)); @@ -161,7 +161,7 @@ public void encodeAsBinary(Message msg, BindValue binding) { case TEXT: case MEDIUMTEXT: case LONGTEXT: - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); if (binding.getCalendar() != null) { buf.append(TimeUtil.getSimpleDateFormat("yyyy-MM-dd HH:mm:ss", binding.getCalendar()).format(x)); diff --git a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/ZonedDateTimeValueEncoder.java b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/ZonedDateTimeValueEncoder.java index 20c7f54bf..5a798de44 100644 --- a/src/main/protocol-impl/java/com/mysql/cj/protocol/a/ZonedDateTimeValueEncoder.java +++ b/src/main/protocol-impl/java/com/mysql/cj/protocol/a/ZonedDateTimeValueEncoder.java @@ -75,7 +75,7 @@ public String getString(BindValue binding) { ((ZonedDateTime) binding.getValue()).withZoneSameInstant(this.serverSession.getDefaultTimeZone().toZoneId()).toLocalDateTime()), binding.getField(), binding.keepOrigNanos()); - StringBuffer buf = new StringBuffer(); + StringBuilder buf = new StringBuilder(); buf.append(TimeUtil.getSimpleDateFormat(null, "''yyyy-MM-dd HH:mm:ss", binding.getMysqlType() == MysqlType.TIMESTAMP && this.preserveInstants.getValue() ? this.serverSession.getSessionTimeZone()