From 6b0225372eaa2cd319ed4706ac54f142cead2633 Mon Sep 17 00:00:00 2001 From: Simon J Mudd Date: Tue, 3 Aug 2021 16:47:43 +0200 Subject: [PATCH] Add endpoint host:port to error message and describe another failure scenario --- .../xcom/gcs_xcom_control_interface.cc | 19 ++++++++++++++----- 1 file changed, 14 insertions(+), 5 deletions(-) diff --git a/plugin/group_replication/libmysqlgcs/src/bindings/xcom/gcs_xcom_control_interface.cc b/plugin/group_replication/libmysqlgcs/src/bindings/xcom/gcs_xcom_control_interface.cc index 5ab213be2c59..62df77002b47 100644 --- a/plugin/group_replication/libmysqlgcs/src/bindings/xcom/gcs_xcom_control_interface.cc +++ b/plugin/group_replication/libmysqlgcs/src/bindings/xcom/gcs_xcom_control_interface.cc @@ -381,7 +381,11 @@ enum_gcs_error Gcs_xcom_control::retry_do_join() { * JoinTestFailedToConnectToXComQueueSignallingMechanism) GCS smoke test. */ MYSQL_GCS_LOG_ERROR("Error connecting to the local group communication" - << " engine instance.") + << " engine instance at " + << m_local_node_address->get_member_ip() + << ":" + << local_port + << ".") goto err; /* purecov: end */ } @@ -392,16 +396,21 @@ enum_gcs_error Gcs_xcom_control::retry_do_join() { XCom instance. If this "test" connection fails, then we fail fast by interrupting the join procedure. - An example of a situation where this connection may fail is when we have an - SSL certificate with invalid identification, and the group is using SSL - with identity verification enabled. + Two examples of a situation where this connection may fail are: + * when we have an SSL certificate with invalid identification, and the + group is using SSL with identity verification enabled. + * an incorrect firewall configuration blocking connections to the endpoint. */ could_connect_to_local_xcom = m_xcom_proxy->test_xcom_tcp_connection( m_local_node_address->get_member_ip(), m_local_node_address->get_member_port()); if (!could_connect_to_local_xcom) { MYSQL_GCS_LOG_ERROR("Error connecting to the local group communication" - << " engine instance.") + << " engine instance at " + << m_local_node_address->get_member_ip() + << ":" + << m_local_node_address->get_member_port() + << ".") goto err; }