Bug #97938 pooling.py missing raise statement

• Submitted: 10 Dec 2019 6:16
• Modified: 11 Dec 2019 23:17
• Reporter: Rastislav Masaryk
• Status: Closed
• Category: Connector / Python
• Severity: S3 (Non-critical)
• Version: 8.0.18
• OS: Any
• CPU Architecture: Any

[10 Dec 2019 6:16] Rastislav Masaryk

Description:
Line 253 in mysql\connector\pooling.py is missing "raise" statement (function _queue_connection())

How to repeat:
atm end of function _queue_connection() looks like this 

try:
    self._cnx_queue.put(cnx, block=False)
except queue.Full:
    errors.PoolError("Failed adding connection; queue is full")

Suggested fix:
add raise statement

try:
    self._cnx_queue.put(cnx, block=False)
except queue.Full:
    raise errors.PoolError("Failed adding connection; queue is full")

[10 Dec 2019 7:27] MySQL Verification Team

Hello Rastislav Masaryk,

Thank you for the report and feedback.
Verifying based on code review.

regards,
Umesh

[11 Dec 2019 23:17] Philip Olson

Posted by developer:
 
Fixed as of the upcoming MySQL Connector/Python 8.0.20 release, and here's the changelog entry:

Added missing raise statement when queue is full. Thanks to Rastislav
Masaryk for the patch.

Thank you for the bug report.