Bug #97435 Contribution: Register Driver with DriverAction to cleanup
Submitted: 30 Oct 2019 14:00 Modified: 16 Jul 2020 11:11
Reporter: OCA Admin (OCA) Email Updates:
Status: Not a Bug Impact on me:
None 
Category:Connector / J Severity:S4 (Feature request)
Version: OS:Any
Assigned to: CPU Architecture:Any

[30 Oct 2019 14:00] OCA Admin 
Description:
This bug tracks a contribution by Yanming Zhou (Github user: quaff) as described in http://github.com/mysql/mysql-connector-j/pull/44

How to repeat:
See description

Suggested fix:
See contribution code attached
[30 Oct 2019 14:00] OCA Admin 
Contribution submitted via Github - Register Driver with DriverAction to cleanup 
(*) Contribution by Yanming Zhou (Github quaff, mysql-connector-j/pull/44#issuecomment-547686374): I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: git_patch_328588768.txt (text/plain), 1001 bytes.
[30 Oct 2019 14:19] MySQL Verification Team 
Thank you for the contribution.
[16 Jul 2020 11:11] Filipe Silva 
Hi Yanming Zhou,

Thank you very much for your contribution.

We can't do what you are suggesting. De-registering the Connector/J driver doesn't mean existing connections can't continue being used. If the Abandoned Connection Cleanup thread is shutdown here we stop monitoring connections still active, thus, defeating its purpose. OTOH, the driver can be re-registered, but the cleanup thread wouldn't be re-spawned.

For the above reasons, I'm sorry but we can't accept your patch.