Bug #96396 redundant code in function que_fork_start_command
Submitted: 1 Aug 2019 9:36 Modified: 1 Aug 2019 10:57
Reporter: xiang wang Email Updates:
Status: Verified Impact on me:
Category:MySQL Server: InnoDB storage engine Severity:S3 (Non-critical)
Version:5.7, 5.7.27, 8.0.17 OS:Any
Assigned to: CPU Architecture:Any

[1 Aug 2019 9:36] xiang wang
quoted code:

	que_fork_t*	fork)	/*!< in: a query fork */
	que_thr_t*	thr;
	que_thr_t*	suspended_thr = NULL;    ------>The first assignment
	que_thr_t*	completed_thr = NULL;    ------>The first assignment

	fork->state = QUE_FORK_ACTIVE;

	fork->last_sel_node = NULL;

	suspended_thr = NULL;                   ------->The second assignment
	completed_thr = NULL;                   ------->The second assignment

How to repeat:
read the code

Suggested fix:
remove the redundant code
[1 Aug 2019 10:57] MySQL Verification Team
Hello xiang wang,

Thank you for the report and feedback.