Bug #96377 include/mysql/get_password.h now completely redundant
Submitted: 30 Jul 2019 13:10 Modified: 1 Aug 2019 11:05
Reporter: Laurynas Biveinis (OCA) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:8.0.17 OS:Any
Assigned to: CPU Architecture:Any

[30 Jul 2019 13:10] Laurynas Biveinis 
Description:
[1] removed get_tty_password_ext implementation. But include/mysql/get_password.h still has its declaration, and also a supporting declaration of strdup_handler_t, which is obsolete too. So the whole file is obsolete now and should be deleted.

[1]:

commit 9a0de512b1653b15bb1d9508d2ecbe28f51d8a38
Author: Georgi Kodinov <georgi.kodinov@oracle.com>
Date:   Fri Mar 22 09:48:03 2019 +0100

    Bug #28121400: LONG PASSWORDS ARE NOT NULL-TERMINATED IN GET_TTY_PASSWORD_EXT()
    RB#21765
    
    There were two versions of get_password.cc in sql-common/ and client/
    And both were exhibiting the same problem.
    Removed the obsolete version (client/get_password.cc) and fixed the
    other one to use the standard C pib copy function and terminate it
    properly.
    No test case since this only applies to manual testing (on a tty).

How to repeat:
See above

Suggested fix:
git rm include/mysql/get_password.h
[30 Jul 2019 15:24] MySQL Verification Team 
Hello Laurynas,

Thank you for your bug report.

I have analysed it and concluded that you are correct.

Verified as reported.
[1 Aug 2019 11:05] Paul DuBois 
Posted by developer:
 
Fixed in 8.0.19.

Code cleanup. No changelog entry required.
[1 Aug 2019 12:54] MySQL Verification Team 
Thank you, Paul.