Bug #94432 MacOS dark mode white lines in results grid should be dark grey instead of white
Submitted: 21 Feb 2019 21:33 Modified: 27 Apr 22:34
Reporter: Romain Riche Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Workbench: SQL Editor Severity:S1 (Critical)
Version:8.0.15/8.0.19 OS:Mac OS X
Assigned to: CPU Architecture:x86
Tags: black, contrast, Dark Mode, white

[21 Feb 2019 21:33] Romain Riche
Description:
the white lines (row / column separator) contrast too much with the black background making it hard to read.

It should replicate the same behavious than the light mode version

light mode: background in white with lines in light grey
dark more: background in black with lines in dark grey

it will be 1000 times more pleasant on the eyes and easier to see the data in white over black...

How to repeat:
run a query with results output

Suggested fix:
very simple: change the color of the white lines to dark grey, I suggest something like #303030
[21 Feb 2019 21:38] Romain Riche
sample

Attachment: Screenshot 2019-02-21 at 10.37.33 PM.png (image/png, text), 40.71 KiB.

[22 Feb 2019 9:47] MySQL Verification Team
Thank you for the bug report.
[25 Feb 2019 12:07] Romain Riche
this is not a feature request but an issue with the dark mode settings. Dark mode should replicate the design of the original "light mode". There is no such high contrast lines on the light mode, so it should be the same in dark mode... thx
[25 Feb 2019 12:12] Romain Riche
comparison between light and dark mode. Dark mode should have no line or at least very soft color like in light mode

Attachment: Screenshot 2019-02-25 at 1.11.19 PM.png (image/png, text), 772.25 KiB.

[9 May 2019 23:30] Romain Riche
any chance to have that changed in 8.0.17 
it should be very quick to change (just darken the color of the grid lines)
[17 Oct 2019 15:03] Pete Sloman
This issue persists in 8.0.18.

Could the results grid use the same color scheme as the field types?

Field types look great in dark mode.
[17 Oct 2019 21:08] Romain Riche
Totally agree with Pete.. Please follow Field Type grid lines it would be perfect.

The result grid is currently unusable in dark mode, the while lines are too strong thus it makes it very hard to read the data content.
[14 Jan 20:19] test test
The same issue in 8.0.19 ... one year known issue and still not fixed
[14 Jan 20:28] Romain Riche
this change must be so quick to do, and yet a year later, still there indeed.
This is the only reason I can't switch to 8.x version.
Data-tables are impossible to read
[14 Jan 20:29] Romain Riche
raising this issue to critical
[14 Jan 21:04] MySQL Verification Team
https://bugs.mysql.com/bug.php?id=98226 marked as duplicate of this one.
[9 Mar 20:46] Romain Riche
any hope for this ?
[27 Apr 22:34] Romain Riche
Just did a quick search in the code and it seems the grid line color is defined here:

frontend/mac/Base.lproj/WbResultsetView.xib

<color key="gridColor" red="0.91372549999999997" green="0.91372549999999997" blue="0.91372549999999997" alpha="1" colorSpace="calibratedRGB"/>

I am not able to compile / commit the change but surely should be quick to do for someone more familiar with the code base.
[13 May 17:20] Pete Sloman
this is still an issue in 8.0.20 (16114288 CE)