| Bug #94349 | cmake cleanup: gcc/clang compiler warning suppressions | ||
|---|---|---|---|
| Submitted: | 15 Feb 2019 15:00 | Modified: | 11 Jul 2019 12:37 |
| Reporter: | Tor Didriksen | Email Updates: | |
| Status: | Closed | Impact on me: | |
| Category: | MySQL Server: Compiling | Severity: | S3 (Non-critical) |
| Version: | 8.0.17 | OS: | Any |
| Assigned to: | CPU Architecture: | Any | |
[11 Jul 2019 12:37]
Paul DuBois
Posted by developer: Fixed in 8.0.18. Configuration cleanup. No changelog entry required.
Description: Unify the handling of testing for compiler warning suppressions. How to repeat: Read the code. We have CHECK_CXX_COMPILER_FLAG("-Wxxxxx" HAVE_XXXXX) spread all over the cmake codebase. This leads to inconsistent, and duplicated code. Suggested fix: Add a new MY_CHECK_CXX_COMPILER_WARNING function, which caches results.