Bug #93478 Contribution by Facebook: Store all_persisted_variables.test counters in va ...
Submitted: 4 Dec 2018 23:02 Modified: 15 Mar 18:20
Reporter: FBContrib Admin Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Tests Severity:S3 (Non-critical)
Version:8.0.13 OS:Any
Assigned to: CPU Architecture:Any

[4 Dec 2018 23:02] FBContrib Admin
Description:
Background innformation provided by Facebook:
This diff changes all_persisted_variables.test to limit the number of hardcoded values in the test output by putting them into local variables. New patches that are then rebased on top which add new system variables do not need to change as many lines of the original test case, making it easier on the rebase process. The output of the lines are already inconsistent with the actual numbers stored in the variable, so attempt to fix that too.

Repo: https://github.com/mysql/mysql-server
Patch on top of 8.0.13: https://github.com/mysql/mysql-server/commit/e4924f36486f971f8a04252e01c803457a2c72f7

How to repeat:
See description

Suggested fix:
See contribution code attached
[4 Dec 2018 23:02] FBContrib Admin
Store all_persisted_variables.test counters in variables 
(*) This code is contributed under the Facebook agreement

Contribution: fb_patch_89.txt (text/plain), 6.40 KiB.

[15 Mar 18:20] Paul Dubois
Posted by developer:
 
Fixed in 8.0.16.

These changes to the all_persisted_variables test were implemented:

* It limits the number of hardcoded values in the test output by putting
  them into local variables. New patches that are then rebased on top that
  add new system variables do not need to change as many lines of the
  original test case, making it easier on the rebase process.

* It removes entries for bugs that were fixed and modifies the queries to
  include the system variables that were not tested due to open bugs.

Thanks to the Facebook team for the contribution.