Bug #91789 Last use of preprocesor define MYSQL_CLIENT
Submitted: 25 Jul 2018 12:33 Modified: 6 Aug 2018 10:38
Reporter: Laurynas Biveinis (OCA) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Document Store: X Plugin Severity:S3 (Non-critical)
Version:8.0.11 OS:Any
Assigned to: CPU Architecture:Any

[25 Jul 2018 12:33] Laurynas Biveinis 
Description:
8.0 replaced preprocessor symbol MYSQL_CLIENT with !MYSQL_SERVER in [1].

But

./plugin/x/src/sql_data_context.h:140:#undef MYSQL_CLIENT

[1]:

commit be029dbf12c91eb1e1133ef70a472c7e5a3b80e2
Author: Jon Olav Hauglid <jon.hauglid@oracle.com>
Date:   Thu Jan 19 15:14:58 2017 +0100

    Bug#25428042: REPLACE MYSQL_CLIENT IFDEF WITH !MYSQL_SERVER
    
    Replace the MYSQL_CLIENT #ifdef with !MYSQL_SERVER to
    simplify conditional compilation.
    
    Also remove unnecessary usage of MYSQL_SERVER
    and move setting of MYSQL_SERVER from C++ to CMake.

How to repeat:
Grep

Suggested fix:
Remove that line
[25 Jul 2018 12:35] Laurynas Biveinis 
Consider using #pragma GCC poison for things you don't want to creep in back into the codebase
[25 Jul 2018 12:53] MySQL Verification Team 
Hello Laurynas,

Thank you for the report and feedback!

regards,
Umesh
[6 Aug 2018 10:38] Margaret Fisher 
Posted by developer:
 
Code cleanup. No changelog entry needed.