Bug #91678 thread_mutex removal leftovers

Submitted: 17 Jul 2018 13:41 Modified: 20 Jul 2018 13:41
Reporter: Laurynas Biveinis (OCA) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: InnoDB storage engine Severity:S3 (Non-critical)
Version:8.0.11 OS:Any
Assigned to: CPU Architecture:Any

[17 Jul 2018 13:41] Laurynas Biveinis 
Description:
8.0 removed thread_mutex at [1] in favor std::thread. But the removal is not complete, here's what remains:

./handler/ha_innodb.cc:647:    PSI_MUTEX_KEY(thread_mutex, 0, 0, PSI_DOCUMENT_ME),
extern mysql_pfs_key_t thread_mutex_key;
./include/sync0sync.h:166:extern mysql_pfs_key_t thread_mutex_key;
./include/sync0types.h:414:  LATCH_ID_THREAD_MUTEX,
./sync/sync0sync.cc:133:mysql_pfs_key_t thread_mutex_key;
./sync/sync0debug.cc:1372:  LATCH_ADD_MUTEX(THREAD_MUTEX, SYNC_NO_ORDER_CHECK, thread_mutex_key);

[1]:

commit a31f512d7b4d6682e5dca3a10125661cee1e42b4
Author: Sunny Bains <Sunny.Bains@oracle.com>
Date:   Wed May 18 23:57:03 2016 +0530

    WL#9273 - Switch to C++11 std::thread
    
    (cherry picked from commit 19cb44d6796a931da5b7226c03e00b9904a00503)
    
    This push has all the other changes from WL#9273 too, to make this work.

How to repeat:
Code analysis

Suggested fix:
Remove the above
[18 Jul 2018 6:16] MySQL Verification Team 
Hello Laurynas,

Thank you for the report and feedback!

Thanks,
Umesh
[20 Jul 2018 13:41] Daniel Price 
Posted by developer:
 
Fixed as of the upcoming 8.0.13 release, and here's the changelog entry:

Leftover thread_mutex code was removed from InnoDB source code files.

Portions of this website are copyright © 2001, 2002 The PHP Group

Page generated in 0.050 sec. using MySQL 8.4.7-u6-cloud

Timestamp references displayed by the system are UTC.
Content reproduced on this site is the property of the respective copyright holders.
It is not reviewed in advance by Oracle and does not necessarily represent the opinion of Oracle or any other party.