MySQL Bugs: #91483: MySQL 8 upgrade checker warns about valid display widths and zerofill

Bug #91483	MySQL 8 upgrade checker warns about valid display widths and zerofill
Submitted:	29 Jun 2018 2:25	Modified:	2 Jul 2018 4:43
Reporter:	monty solomon	Email Updates:
Status:	Duplicate	Impact on me:	None
Category:	Shell Upgrade Checker	Severity:	S3 (Non-critical)
Version:	8.0.11	OS:	Any
Assigned to:		CPU Architecture:	Any

Description:
The Upgrade Checker warns

3) Usage of use ZEROFILL/display length type attributes
  Notice: The following table columns specify a ZEROFILL/display length attributes. Please be aware that they will be ignored in MySQL 8.0

Those features are supported in version 8. Why does it warn about them and state they will be ignored?

https://dev.mysql.com/doc/refman/8.0/en/numeric-type-attributes.html

https://dev.mysql.com/doc/refman/8.0/en/numeric-type-overview.html

How to repeat:
running mysql 5.7.18

create database foo; 
use foo;
create table bar (a boolean primary key) engine=innodb;
show create table bar\G
*************************** 1. row ***************************
       Table: bar
Create Table: CREATE TABLE `bar` (
  `a` tinyint(1) NOT NULL,
  PRIMARY KEY (`a`)
) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4

quit

run mysqlsh 8.0.11

mysqlsh --py localhost
util.check_for_server_upgrade("localhost");

3) Usage of use ZEROFILL/display length type attributes
  Notice: The following table columns specify a ZEROFILL/display length attributes. Please be aware that they will be ignored in MySQL 8.0

  foo.bar.a - tinyint(1)

Suggested fix:
Remove the incorrect warnings from the upgrade checker

Hello Monty,

Thank you for the report!

Thanks,
Umesh

Confirmed with Developer internally that this is duplicate of Bug #90634, per Changelog entry added for MySQL 8.0.13:
The checkForServerUpgrade() operation to verify upgrade prerequisites included an unnecessary check relating to ZEROFILL and display length attributes in columns. The check has now been removed.