MySQL Bugs: #91409: fix bad usage of assert()

Bug #91409	fix bad usage of assert()
Submitted:	25 Jun 2018 13:18	Modified:	28 Jun 2018 13:34
Reporter:	Tor Didriksen	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Compiling	Severity:	S3 (Non-critical)
Version:	8.0.13	OS:	Any
Assigned to:		CPU Architecture:	Any

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
The codebase has a few instances of assert() rather than the MySQL DBUG_ASSERT.
Building with -DNDEBUG, the standard way of disabling assert() gives warnings.

How to repeat:
CPPFLAGS=-DNDEBUG cmake .... -DMYSQL_MAINTAINER_MODE=1
CPPFLAGS=-DNDEBUG make

Suggested fix:
Decorate code with MY_ATTRIBUTE((unused))
This is a prerequisite for fixing:
Bug #27874068 ADD SUPPORT FOR -DCMAKE_BUILD_TYPE=RELEASE

Posted by developer:
 
Fixed in 8.0.13.

Code cleanup. No changelog entry needed.