| Bug #91191 | Improvement suggestions for mysql upgrade checker | ||
|---|---|---|---|
| Submitted: | 8 Jun 2018 17:52 | Modified: | 9 Jun 2018 6:08 |
| Reporter: | Simon Mudd (OCA) | Email Updates: | |
| Status: | Verified | Impact on me: | |
| Category: | Shell Upgrade Checker | Severity: | S4 (Feature request) |
| Version: | 8.0.11 | OS: | Any |
| Assigned to: | CPU Architecture: | Any | |
| Tags: | upgrade checker. | ||
[8 Jun 2018 18:10]
Simon Mudd
A question related to the reserved word check. I saw a warning like this: some_schema.some_table.rank - Column name Is there a way to check if this is already being done correctly? That is I can use P_S to validate if the current queries already correctly quote these columns or not? It would be nice to know that if possible as some code may do the right thing and other code may not, or as we fix things we'd like to know if we've fixed everything or just a part.
[9 Jun 2018 6:08]
MySQL Verification Team
Hello Simon, Thank you for the feature request! Thanks, Umesh
Description: I actually requested some thing like this ages ago when doing 5.0 to 5.1 upgrades so it's good to see it's now here. However, I don't really use the mysql shell much and a recent post on planet brought it to my attention. I really think the mysql-shell should be included as part of the command line client utilities if you want people to use this as it's very easy to miss. Anyway, the checker ran on a box I have and came up with a few warnings. I ran this on a 5.7 box I use and it came up with a few warnings. How to repeat: run the checker something like this: MySQL JS > util.checkForServerUpgrade('user@host:3306', 'password') Suggested fix: * make this work with a socket connection. Many of my all privilege users use a connection over a unix socket. I couldn't figure out how to do that with mysql shell. Make sure examples also show this. * for each point apart from the short text you provide please provide a pointer to a URL which gives more detail. * the reserved words check is quite clear. * the utfmb3 check is a bit confusing for people who think this is utf8. A clearer message might help but the link to a more complete explanation in a URL would also be good. * the "Usage of use ZEROFILL/display length type attributes" check I didn't really understand. To me it's not clear what it s saying. If the display width will be ignored in 8.0 that's fine but again a pointer to a URL with a better explanation would be very helpful as I find a large number of columns generating this warning. * add a counter for each type of warning as I had quite a few. If I was going to look at each of these and fix them and run the check again from time to time the counter would be an easier way to validate my progress.