Bug #89377 -DWITH_SSL=system docs should explain what "system" means on macOS and Windows

• Submitted: 24 Jan 2018 10:32
• Modified: 20 Mar 2018 23:32
• Reporter: Laurynas Biveinis (OCA)
• Status: Closed
• Category: MySQL Server: Documentation
• Severity: S3 (Non-critical)
• Version: 8.0.4
• OS: Any
• CPU Architecture: Any
• Tags: cmake, doc, macos, SSL, windows

[24 Jan 2018 10:32] Laurynas Biveinis

Description:
8.0.4 implemented -DWITH_SSL=system support for macOS and Windows. It is explained inn the bug report / commit message that these do not carry system-shipped OpenSSL, but that 3rd party Win32 OpenSSL / brew packages are searched for instead. But this is not explained on https://dev.mysql.com/doc/refman/8.0/en/source-configuration-options.html#option_cmake_wit...

How to repeat:
See above

Suggested fix:
Document the meaning of "system" for macOS and Windows at https://dev.mysql.com/doc/refman/8.0/en/source-configuration-options.html#option_cmake_wit...

[24 Jan 2018 11:26] MySQL Verification Team

Hello Laurynas,

Thank you for the report and feedback.

Thanks,
Umesh

[6 Feb 2018 23:00] Philip Olson

Posted by developer:
 
Thank you for this bug report, the following was added to the -DWITH_SSL=system's 8.0 documentation:

On macOS and Windows, using 'system' builds as if CMake was invoked with
'path_name' and points to the installed OpenSSL library. This is because
they do not have system SSL libraries. For example, if 'brew install
openssl' installs to '/usr/local/opt/openssl' then using system will find
and use '/usr/local/opt/openssl'. 

Please review and confirm if this does (or does not) meet your expectations. All suggestions and improvements are welcome!

As a reference, the bug that added -DWITH_SSL=system support to macOS and Windows is MySQL Bug #87938

[7 Feb 2018 3:30] Laurynas Biveinis

Thanks, I'd suggest to enumerate those 'path_name' values for macOS and Windows, together with their 3rd party sources respectively.

[20 Mar 2018 23:32] Philip Olson

Posted by developer:
 
Thank you for the update and reporting this doc bug, and sorry for the delay. It now reads as (minus the formatting):

On macOS and Windows, using system builds as if CMake was invoked with
path_name and points to the installed OpenSSL library. This is because
they do not have system SSL libraries. On macOS, brew install openssl
installs to /usr/local/opt/openssl and system will find it. On Windows, it
checks %ProgramFiles%/OpenSSL, %ProgramFiles%/OpenSSL-Win32,
%ProgramFiles%/OpenSSL-Win64, C:/OpenSSL, C:/OpenSSL-Win32, and
C:/OpenSSL-Win64.