Bug #88960 Contribution: missing header on Linux
Submitted: 18 Dec 2017 16:29 Modified: 31 Jan 2019 12:30
Reporter: OCA Admin (OCA) Email Updates:
Status: Can't repeat Impact on me:
None 
Category:MySQL Server: Performance Schema Severity:S3 (Non-critical)
Version:5.7 OS:Any
Assigned to: Marc ALFF CPU Architecture:Any
Tags: Contribution

[18 Dec 2017 16:29] OCA Admin 
Description:
This bug tracks a contribution by David CARLIER (Github user: devnexen) as described in http://github.com/mysql/mysql-server/pull/185

How to repeat:
See description

Suggested fix:
See contribution code attached
[18 Dec 2017 16:29] OCA Admin 
Contribution submitted via Github - missing header on Linux 
(*) Contribution by David CARLIER (Github devnexen, mysql-server/pull/185#issuecomment-352422029): I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: git_patch_158754391.txt (text/plain), 631 bytes.
[19 Dec 2017 7:27] MySQL Verification Team 
Hello David CARLIER,

Thank you for the report and contribution.

Thanks,
Umesh
[31 Jan 2019 11:08] Marc ALFF 
[ Late reply, I know ... ]

David,

The contribution proposes to use the malloc.h header file on Linux,
but does not describe why this is actually needed, and what issue it resolves.

For Linux, the code in pfs_global.cc uses malloc() and posix_memalign(),
which are both, according to the man pages, declared in stdlib.h,
and pfs_global.cc already includes stdlib.h ...

In light of this, the proposed patch does not appear to be correct (to me).

Beside, MySQL builds already on a wide variety of different Linux distributions,
and no issue related to a missing malloc.h in pfs_global.cc was ever found,
which raise the question about the actual problem the patch intends to fix.

If this fix is really needed, then please clarify:
- which Linux distribution exactly is affected, so we could check the header files there,
- what is the build failure found, if any.

Regards,
-- Marc Alff
[31 Jan 2019 11:33] David CARLIER 
I think there were a compilation issue at the time, it must have been solved since more than one year. This patch can be forgotten then.
[31 Jan 2019 12:29] Marc ALFF 
Hi David,

Thanks for the reply.

Closing this issue then.

-- Marc Alff