MySQL Bugs: #87319: Label for "SSL Certificate Authority" is truncated

Bug #87319	Label for "SSL Certificate Authority" is truncated
Submitted:	4 Aug 2017 8:35	Modified:	10 Nov 2017 7:30
Reporter:	Daniël van Eeden (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	Connector / ODBC	Severity:	S3 (Non-critical)
Version:	5.3.8	OS:	Windows
Assigned to:	Bogdan Degtyariov	CPU Architecture:	Any
Tags:	regression

Description:
The label for "SSL Certificate Authority" in the Data Source Configuration dialog is truncated to "SSL Certificate".

The result:
"SSL Cerfificate" is listed twice. Only the first one has a underscore on the C.

The only place to enter a CA is now "SSL CA Path" which is very confusing to users.

How to repeat:
Open the data source configuration dialog and expand details and go the the SSL tab.

Suggested fix:
Fix this line:

https://github.com/mysql/mysql-connector-odbc/blob/master/setupgui/windows/odbcdialogparam...

222     RTEXT           "SSL &Certificate",IDC_STATIC,6,27,78,11
223     EDITTEXT        IDC_EDIT_sslcert,90,25,97,12,ES_AUTOHSCROLL
224     RTEXT           "SSL Certificate &Authority",IDC_STATIC,6,45,79,8
225     EDITTEXT        IDC_EDIT_sslca,90,43,97,12,ES_AUTOHSCROLL

Note that the RTEXT for both have a very similar witdth.

From https://msdn.microsoft.com/en-us/library/windows/desktop/aa381044(v=vs.85).aspx
RTEXT text, id, x, y, width, height [, style [, extended-style]]

So either:
1. Increase the width property of the RTEXT to something like 150
2. Change the text to "SSL C&A File" to be more similar to the "SSL CA Path" option. (probably the best option)

Screenshot

Attachment: 1edni.png (image/png, text), 80.51 KiB.

Only happens on Windows..

Hello Daniel,

Thank you for the report.
I'm not seeing the issue with Connector/ODBC 5.3.9 on win7. Could you please confirm if you are seeing this issue with Connector/ODBC 5.3.9 GA?

regards,
Umesh

Screenshot..

Attachment: 87319_5.3.9.png (image/png, text), 34.01 KiB.

Win10 - 5.3.8

Attachment: Win10_5.3.8.JPG (image/jpeg, text), 84.75 KiB.

Win10 - 5.3.9

Attachment: Win10_5.3.9.JPG (image/jpeg, text), 86.65 KiB.

Hi Daniel,

We confirmed at our end that it's not reproducible on Win7/Win10 with 5.3.8/5.3.9. Could you please confirm the exact environment where you have seen the issue?

Thanks,
Umesh

Env:
Connector/ODBC 5.3.8 X64
Microsoft Windows 7 Enterprise - SP1  - Build 7601 
Microsoft .NET framework 4.5.2
Microsoft Visual C++ 2013 X64 - 12.0.30501

Looking at the screenshots I see:
1. Font rendering looks different. Please test with ClearType turned on.
2. The close button in the topright of the window looks different.
3. In your screenshot it is not showing keyboard shortcuts (e.g. underscore under the P of Port)

Thank you Daniel.
Verifying based on my internal discussion with BogdanD.

Thanks,
Umesh

Thank you Daniël for your contribution.
I looks reasonable. Also, it aligns well with another label "SSL CA Directory", which already exists in the ODBC GUI dialog.

Another thing is the bug severity. I is clearly not S1 (complete loss of service, no workarounds) or S2 (severe loss of service). Changing the severity to S3.

Directly related to #87325