Bug #87124 MTR test sys_vars.temptable_max_ram_basic is missing its result file
Submitted: 19 Jul 2017 16:12 Modified: 31 Jul 2017 5:36
Reporter: Laurynas Biveinis (OCA) Email Updates:
Status: Closed Impact on me:
None 
Category:Tests: Server Severity:S3 (Non-critical)
Version:8.0.2 OS:Any
Assigned to: CPU Architecture:Any
Tags: mtr

[19 Jul 2017 16:12] Laurynas Biveinis
Description:
MTR test sys_vars.temptable_max_ram_basic is missing its result file

How to repeat:
./mtr temptable_max_ram_basic
...
worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
1073741824
SELECT @@session.temptable_max_ram;
ERROR HY000: Variable 'temptable_max_ram' is a GLOBAL variable
SET @@global.temptable_max_ram = 5666777;
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
5666777
SET @@global.temptable_max_ram = -5666777;
Warnings:
Warning	1292	Truncated incorrect temptable_max_ram value: '-5666777'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
2097152
SET @@global.temptable_max_ram = -1;
Warnings:
Warning	1292	Truncated incorrect temptable_max_ram value: '-1'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
2097152
SET @@global.temptable_max_ram = 0;
Warnings:
Warning	1292	Truncated incorrect temptable_max_ram value: '0'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
2097152
SET @@global.temptable_max_ram = 1;
Warnings:
Warning	1292	Truncated incorrect temptable_max_ram value: '1'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
2097152
SET @@global.temptable_max_ram = default;
SET @@global.temptable_max_ram = NULL;
ERROR 42000: Incorrect argument type to variable 'temptable_max_ram'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
1073741824
SET @@global.temptable_max_ram = 'foo';
ERROR 42000: Incorrect argument type to variable 'temptable_max_ram'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
1073741824
sys_vars.temptable_max_ram_basic         [ pass ]     15

Suggested fix:
Record, commit, maybe add some warnings to to the test runner when it finds a .result-less test
[20 Jul 2017 4:25] Umesh Shastry
Hello Laurynas,

Thank you for the report and feedback!

Thanks,
Umesh
[20 Jul 2017 4:26] Umesh Shastry
-- 8.0.2

[umshastr@hod03]/export/umesh/server/binaries/Trunk/mysql-8.0.2-dmr-linux-glibc2.12-x86_64/mysql-test: ./mtr temptable_max_ram_basic
Logging: ./mtr  temptable_max_ram_basic
MySQL Version 8.0.2
Too long tmpdir path '/export/umesh/server/binaries/Trunk/mysql-8.0.2-dmr-linux-glibc2.12-x86_64/mysql-test/var/tmp'  creating a shorter one...
 - using tmpdir: '/tmp/AU1S98Jj4r'

Checking supported features...
 - SSL connections supported
Collecting tests...
Removing old var directory...
Creating var directory '/export/umesh/server/binaries/Trunk/mysql-8.0.2-dmr-linux-glibc2.12-x86_64/mysql-test/var'...
Installing system database...
Using parallel: 1

==============================================================================

TEST                                      RESULT   TIME (ms) or COMMENT
--------------------------------------------------------------------------

worker[1] Using MTR_BUILD_THREAD 300, with reserved ports 13000..13009
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
1073741824
SELECT @@session.temptable_max_ram;
ERROR HY000: Variable 'temptable_max_ram' is a GLOBAL variable
SET @@global.temptable_max_ram = 5666777;
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
5666777
SET @@global.temptable_max_ram = -5666777;
Warnings:
Warning 1292    Truncated incorrect temptable_max_ram value: '-5666777'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
2097152
SET @@global.temptable_max_ram = -1;
Warnings:
Warning 1292    Truncated incorrect temptable_max_ram value: '-1'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
2097152
SET @@global.temptable_max_ram = 0;
Warnings:
Warning 1292    Truncated incorrect temptable_max_ram value: '0'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
2097152
SET @@global.temptable_max_ram = 1;
Warnings:
Warning 1292    Truncated incorrect temptable_max_ram value: '1'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
2097152
SET @@global.temptable_max_ram = default;
SET @@global.temptable_max_ram = NULL;
ERROR 42000: Incorrect argument type to variable 'temptable_max_ram'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
1073741824
SET @@global.temptable_max_ram = 'foo';
ERROR 42000: Incorrect argument type to variable 'temptable_max_ram'
SELECT @@global.temptable_max_ram;
@@global.temptable_max_ram
1073741824
sys_vars.temptable_max_ram_basic         [ pass ]      2
--------------------------------------------------------------------------
The servers were restarted 0 times
Spent 0.002 of 5 seconds executing testcases

Completed: All 1 tests were successful.

--
find . -name temptable_max_ram_basic*
./suite/sys_vars/t/temptable_max_ram_basic.test
[umshastr@hod03]/export/umesh/server/binaries/Trunk/mysql-8.0.2-dmr-linux-glibc2.12-x86_64/mysql-test:
[25 Jul 2017 10:54] Erlend Dahl
The plan is to change MTR to fail a test if it doesn't have a .result file.
[25 Jul 2017 10:55] Erlend Dahl
The missing result file has already been added in 8.0.3.
[31 Jul 2017 5:36] Laurynas Biveinis
See also bug 87255