Bug #85297 unreachable code in check_track_session_sys_vars

• Submitted: 3 Mar 2017 17:04
• Reporter: Shane Bester (Platinum Quality Contributor)
• Status: Verified
• Category: MySQL Server: Options
• Severity: S3 (Non-critical)
• Version: 5.7+
• OS: Any
• CPU Architecture: Any

[3 Mar 2017 17:04] Shane Bester

Description:
look at https://github.com/mysql/mysql-server/blob/5.7/sql/sys_vars.cc#L5540

static bool check_track_session_sys_vars(sys_var *self, THD *thd, set_var *var)
{
  DBUG_ENTER("check_sysvar_change_reporter");
  DBUG_RETURN(thd->session_tracker.get_tracker(SESSION_SYSVARS_TRACKER)->check(thd, var));
  DBUG_RETURN(false);
}

the second DBUG_RETURN is dead code.

1>e:\git\mysql-trunk\sql\sys_vars.cc(6076): warning C4702: unreachable code

How to repeat:
see compiler warnings

Suggested fix:
...