Bug #84619 REMOVE #IFDEF HAVE_NDB_BINLOG
Submitted: 23 Jan 2017 14:59 Modified: 25 Jan 2017 17:39
Reporter: Magnus Blåudd Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:8.0.1 OS:Any
Assigned to: CPU Architecture:Any

[23 Jan 2017 14:59] Magnus Blåudd 
Description:
With embedded server removed, HAVE_NDB_BINLOG is always true.
HAVE_NDB_BINLOG ifdef checks can therefore be removed.

How to repeat:
Code inspection and also below from storage/ndb/CMakeLists.txt

# Add HAVE_NDB_BINLOG to the list of compile definitions used when compiling
# the ndbcluster plugin library(NOTE! there is also ndbcluster_embedded which
# is compiled without this define)
IF(NOT WITHOUT_SERVER)

  # Add HAVE_NDB_BINLOG to the list of compile definitions used when compiling
  # the ndbcluster plugin library(NOTE! there is also ndbcluster_embedded which
  # is compiled without this define)
  NDB_ADD_TARGET_PROPERTY(ndbcluster COMPILE_DEFINITIONS "HAVE_NDB_BINLOG")
ENDIF()
[25 Jan 2017 17:39] Paul DuBois 
Posted by developer:
 
Fixed in 8.0.1.

Code cleanup. No changelog entry needed.