Bug #84073 Make Item::null_value bool
Submitted: 6 Dec 2016 8:46 Modified: 8 Dec 2016 15:41
Reporter: Norvald Ryeng Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Optimizer Severity:S3 (Non-critical)
Version: OS:Any
Assigned to: CPU Architecture:Any

[6 Dec 2016 8:46] Norvald Ryeng 
Description:
Item::null_value is of type my_bool, i.e., char. The bool type was standardized in C++98 and C99, so there is no reason to keep using my_bool. New code is written using bool, but that leads to type mismatches when functions want to set the null value using a pointer argument. This has led to a lot of relatively new code using my_bool as a simple way out.

The null_value variable is the only remaining my_bool in the Item class.

How to repeat:
N/A

Suggested fix:
Declare Item::null_value bool.
[8 Dec 2016 15:41] Paul DuBois 
Posted by developer:
 
Fixed in 8.0.1.

Code cleanup. No changelog entry needed.