Bug #84062 Use logic to change multiple checks to a single check (contribution)
Submitted: 5 Dec 2016 14:31 Modified: 19 Dec 2016 19:06
Reporter: OCA Admin (OCA) Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: DML Severity:S3 (Non-critical)
Version: OS:Any
Assigned to: CPU Architecture:Any

[5 Dec 2016 14:31] OCA Admin
Description:
This bug tracks a contribution by Daniel Black (Github user: grooverdan) as described in http://github.com/mysql/mysql-server/pull/114

How to repeat:
See description

Suggested fix:
See contribution code attached
[5 Dec 2016 14:31] OCA Admin
Contribution submitted via Github - Use logic to change multiple checks to a single check 
(*) Contribution by Daniel Black (Github grooverdan, mysql-server/pull/114#issuecomment-264085007): I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.

Contribution: git_patch_96030039.txt (text/plain), 2.33 KiB.

[5 Dec 2016 15:15] MySQL Verification Team
Thank you for the contribution.
[16 Dec 2016 8:52] Norvald Ryeng
Posted by developer:
 
Thanks for the contribution!

We're using C++11 now, so I was able to use std::isfinite() instead of my_isfinite() in C++ code. MyISAM is still C, though, so we have to use my_isfinite() there.
[19 Dec 2016 19:06] Paul DuBois
Posted by developer:
 
Noted in 8.0.1 changelog.

Some GIS out-of-bounds checking was simplified. Thanks to Daniel
Black for the contribution.