Bug #83997 build mysqlpump with sunpro

• Submitted: 29 Nov 2016 7:11
• Modified: 30 Nov 2016 18:09
• Reporter: Tor Didriksen
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 8.0.1
• OS: Any
• CPU Architecture: Any

[29 Nov 2016 7:11] Tor Didriksen

Description:
We have switched from gcc to developer studio for building the server.
We should always build mysqlpump as well.

How to repeat:
Read the code.

Suggested fix:
Remove this:

IF (CMAKE_CXX_COMPILER_ID STREQUAL "SunPro")
  IF (WITHOUT_SERVER)
    MESSAGE(STATUS "Not building mysqlpump")
    RETURN()
  ENDIF()
ENDIF()

[29 Nov 2016 9:29] Tor Didriksen

Posted by developer:
 
in cmake/build_configurations/mysql_release.cmake remove

# Release builds on Solaris need to do an extra build to compile the
# client libraries with Sun Studio. The release build script will replace
# those libraries and the corresponding mysql_config before making the
# final package.
# But *this* mysql_config is still relevant for the embedded library
# which will not be rebuilt, so we ensure we make a copy of it.

IF(CMAKE_SYSTEM_NAME MATCHES "SunOS" AND CMAKE_COMPILER_IS_GNUCC)
  SET(COPY_MYSQL_CONFIG 1 CACHE BOOL "")
ENDIF()

[29 Nov 2016 9:32] Tor Didriksen

Posted by developer:
 
mysql-test/lib/My/SafeProcess/CMakeLists.txt
These are leftovers from -stlport build

# Remove useless -R link options
IF(CMAKE_SYSTEM_NAME MATCHES "SunOS")
  IF(CMAKE_CXX_COMPILER_ID MATCHES "SunPro")  
    STRING(REGEX REPLACE " -R[^ ]+" "" CMAKE_CXX_LINK_FLAGS "${CMAKE_CXX_LINK_FLAGS}")
  ENDIF()
ENDIF()

[30 Nov 2016 18:09] Paul DuBois

Posted by developer:
 
Fixed in 8.0.1.

Code cleanup. No changelog entry needed.