Bug #83767 Consistently declare overridden virtual functions in Geometry subclasses
Submitted: 10 Nov 2016 9:34 Modified: 10 Nov 2016 19:38
Reporter: Marko Mäkelä Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Optimizer Severity:S3 (Non-critical)
Version:8.0.1 OS:Any
Assigned to: CPU Architecture:Any

[10 Nov 2016 9:34] Marko Mäkelä 
Description:
Clang reports warnings if some but not all overridden virtual member functions in a derived class are tagged with the C++11 override keyword.

WL#9432 Axis order in ST_AsBinary/ST_AsWKB
introduced some virtual member functions that were declared with the override keyword, such as Geometry::reverse_coordinates().

How to repeat:
CC=clang-4.0 CXX=clang++-4.0 cmake /path/to/source/of/mysql
make

Suggested fix:
Tag all overridden virtual member functions in Geometry subclasses.
[10 Nov 2016 19:38] Paul DuBois 
Posted by developer:
 
Fixed in 8.0.1.

Code cleanup. No changelog entry needed.