Bug #83669 Remove unused parameter names in Item member functions
Submitted: 3 Nov 2016 11:42 Modified: 9 Nov 2016 15:22
Reporter: Marko Mäkelä Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Optimizer Severity:S3 (Non-critical)
Version:8.0.1 OS:Any
Assigned to: CPU Architecture:Any

[3 Nov 2016 11:42] Marko Mäkelä
Description:
Some virtual member functions of class Item are not using their parameters, preventing us from enabling compile-time warnings for unused parameters. C++ allows the names of unused parameter names to be omitted in function definitions.

How to repeat:
Read the code. For example, many implementations of resolve_type() and neg_transformer() do not use the parameter THD *thd.

Suggested fix:
Remove the names of unused parameters.
[9 Nov 2016 15:22] Paul DuBois
Posted by developer:
 
Fixed in 8.0.1.

Code cleanup. No changelog entry needed.