MySQL Bugs: #83558: Is this a wrong stage?

Bug #83558	Is this a wrong stage?
Submitted:	27 Oct 2016 3:16	Modified:	27 Oct 2016 12:38
Reporter:	yx jiang	Email Updates:
Status:	Not a Bug	Impact on me:	None
Category:	MySQL Server: DML	Severity:	S3 (Non-critical)
Version:	5.7.16	OS:	Any
Assigned to:		CPU Architecture:	Any

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
file:sql_insert.cc
line:663
code:"THD_STAGE_INFO(thd, stage_update);"
Should this be "THD_STAGE_INFO(thd, stage_insert);"?

I think it should be insert stage.

How to repeat:
N/A

Suggested fix:
Replace "THD_STAGE_INFO(thd, stage_update);" with "THD_STAGE_INFO(thd, stage_insert);"

Hi!

Thank you for your bug report. However, in spite of being located in the insert function of the code, the status is correct. Namely, that part of code is dealing with the replacement of the duplicates. Hence, "update" describes what is happening in that part of the code, much better then "insert".

Hence, no changes .....