Bug #83556 mysqlfailover's ping option don't work as expected.

• Submitted: 27 Oct 2016 2:23
• Modified: 27 Oct 2016 4:56
• Reporter: Meiji Kimura
• Status: Verified
• Category: MySQL Utilities
• Severity: S3 (Non-critical)
• Version: 1.5.6, 1.6.4
• OS: Any
• CPU Architecture: Any

[27 Oct 2016 2:23] Meiji Kimura

Description:
After modification of Bug #69212, ping option was documented.

--ping=number

The code uses three attempts to contact the server with the ping command as part of the detection algorithm to check to see if the master is alive. This option sets the number of seconds to wait between each ping attempt. The default --ping value is 3 seconds.

https://dev.mysql.com/doc/mysql-utilities/1.6/en/mysqlfailover.html#option_mysqlfailover_p...
https://dev.mysql.com/doc/mysql-utilities/1.5/en/mysqlfailover.html#option_mysqlfailover_p...

But setting --ping value is always ignored.

How to repeat:
Set ping not default values(e.g. 5 or so)

Suggested fix:
I read source codes. mysqlfailover try to get 'pingtime' for this.

mysql/utilities/command/rpl_admin.py
mysql/utilities/command/failover_daemon.py

self.pingtime = int(self.options.get("pingtime", 3))

But mysqlfailover don't use "pingtime" option, so always set default values(3).

Change option from 'ping' to 'pingtime' on command line, 
of change source code from 'pingtime' to 'ping'.

[27 Oct 2016 4:56] MySQL Verification Team

Hello Meiji-San,

Thank you for the report and feedback!

Thanks,
Umesh