MySQL Bugs: #83254: Add debug checks to JOIN

Bug #83254	Add debug checks to JOIN_CACHE
Submitted:	4 Oct 2016 15:42	Modified:	16 Nov 2016 2:20
Reporter:	Marko Mäkelä	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Optimizer	Severity:	S3 (Non-critical)
Version:	8.0.1	OS:	Any
Assigned to:		CPU Architecture:	Any

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
In JOIN_CACHE::rem_space() there is a redundant std::max operation. We should check better that there is no overflow.

Also, we should assert that after JOIN_CACHE_BKA::init_mrr_buff() has been invoked, the join buffer must no longer be used by JOIN_CACHE::write_record_data() without prior JOIN_CACHE::reset_cache(for_writing=true).

How to repeat:
See Description.

Suggested fix:
See Description.

Posted by developer:
 
Fixed in 8.0.1.

Code cleanup. No changelog entry needed.