MySQL Bugs: #80883: ha_ndbcluster::print

Bug #80883	ha_ndbcluster::print_error remove useless else
Submitted:	29 Mar 2016 12:33	Modified:	28 Apr 2016 12:29
Reporter:	Magnus Blåudd	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Cluster: Cluster (NDB) storage engine	Severity:	S3 (Non-critical)
Version:	7.5.2	OS:	Any
Assigned to:		CPU Architecture:	Any

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
The ha_ndbcluster::print_error() function has a useless else branch which encapsulates all code in the whole function. This obfuscates the function and you loose context when reading it.

How to repeat:
MCI

Suggested fix:
Add a DBUG_VOID_RETURN after m_part_info->print_no_partition_found(table); and then remove the "else {" block. Shift all the code left.

Code change only; no user-visible impact.

Closed.