Bug #80684 Remove dubious DROP_SYNC code from ha_ndbcluster_binlog.cc
Submitted: 10 Mar 2016 9:37 Modified: 26 Apr 2016 18:32
Reporter: Magnus Blåudd Email Updates:
Status: Closed Impact on me:
Category:MySQL Cluster: Cluster (NDB) storage engine Severity:S3 (Non-critical)
Version:7.5.1 OS:Any
Assigned to: CPU Architecture:Any

[10 Mar 2016 9:37] Magnus Blåudd
The ha_ndbcluster_binlog.cc code has some dubious code and comment stating that:

"Synchronized drop between client thread and injector thread is
necessary in order to maintain ordering in the binlog,
such that the drop occurs _after_ any inserts/updates/deletes."

Currently we see no way to avoid this synchronization and thus we can remove the outdated else branch of
#ifdef DROP_SYNC conditional code and fix the comment.

How to repeat:
MCI, found while reviewing related code. Removal already suggested but as part of another bug fix.

We should not forget to do these important cleanups to improve readability of the code.  

Suggested fix:
Remove else branch of #ifdef DROP_SYNC code and fix the comment.
[26 Apr 2016 18:32] Jon Stephens
Fixed in NDB 7.5.2. Refactoring only; no changelog entry needed.