Bug #80683 Refactor ndb_binlog_setup into own class
Submitted: 10 Mar 2016 9:23 Modified: 26 Apr 2016 18:30
Reporter: Magnus Blåudd Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Cluster: Cluster (NDB) storage engine Severity:S3 (Non-critical)
Version:7.5.1 OS:Any
Assigned to: CPU Architecture:Any

[10 Mar 2016 9:23] Magnus Blåudd 
Description:
The ndb_binlog_setup() code in ha_ndbcluster_binlog.cc consists of a couple of functions. In order to make it clear that those belong together we should convert them into a Ndb_binlog_setup class. This will allow to remove duplicated repetitive code as well as simplify the existing code over time. 

How to repeat:
MCI found while reviewing other ndb binlog setup code. 

Suggested fix:
Encapsulate ndb_binlog_setup(), ndbcluster_find_all_files(), ndbcluster_find_fall_databases() and clean_away_stray_files() into a new Ndb_binlog_setup class. The class shoudl then be instantiated from existing ndb_binlog_setup() function a new setup() function called.
[26 Apr 2016 18:30] Jon Stephens 
Refactoring only; no changelog entry needed. Fixed in NDB 7.5.2. Closed.