Bug #79361 Ndb unit tests warnings and linking
Submitted: 20 Nov 2015 11:49 Modified: 24 Nov 2015 11:53
Reporter: Magnus Blåudd Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Cluster: Cluster (NDB) storage engine Severity:S3 (Non-critical)
Version:7.5.0 OS:Any
Assigned to: CPU Architecture:Any

[20 Nov 2015 11:49] Magnus Blåudd 
Description:
The unit tests for ndb are all built using the NdbTap.hpp wrapper file which provides support for TAP by including the "tap" implementation in unittest/mytap/. This is done by including tap.c directly into the header file and has worked pretty ok until the tap implementation started to use funtionality also from other parts of the system. We did some workarounds to also include stacktrace.c into the NdbTap.hpp file. That usually works fine but generates unnecessary compiler warnings and potentially linking problems.

How to repeat:
Compile on osx, problem reports about linking etc.

Suggested fix:
Remove the includes for tap.c and stacktrace.c (plus all the hacks) and instead link with mytap library. This is a fairly easy fix now when we have the new NDB_ADD_TEST macro used for all ndb unit tests.
[24 Nov 2015 11:53] Jon Stephens 
Fixed in NDB 7.5.0. Affects testing only. Closed.