Bug #79237 do not include hash.h from sql_common.h

• Submitted: 11 Nov 2015 15:42
• Modified: 13 Nov 2015 14:57
• Reporter: Tor Didriksen
• Status: Closed
• Category: MySQL Server: Compiling
• Severity: S3 (Non-critical)
• Version: 8.0
• OS: Any
• CPU Architecture: Any

[11 Nov 2015 15:42] Tor Didriksen

Description:
sql_common.h is a file which we INSTALL and deliver.
It #includes hash.h which is *not* shipped with our packages.

Remove this dependency by hiding the HASH struct in use.

How to repeat:
Read the code.

Suggested fix:
Hide it as a pointer to an anonymous struct.

[13 Nov 2015 14:57] Paul DuBois

Fixed in 5.8.0. Bug affects no released version. No changelog entry needed.

[13 Nov 2015 15:16] Paul DuBois

Correction: Noted in 5.8.0 changelog.

sql_common.h, a header file included in MySQL distributions, included
and was therefore dependent on hash.h, a header file not included in
MySQL distributions. This resulted in compilation failures. To
eliminate this dependency, sql_common.h was modified to no longer
include hash.h.

[18 Jun 2016 21:34] Omer Barnir

Posted by developer:
 
Reported version value updated to reflect release name change from 5.8 to 8.0