Bug #78616 76627 documented as fixed in 5.5.45 but no trace of fix

• Submitted: 29 Sep 2015 7:40
• Modified: 30 Oct 2015 12:53
• Reporter: Laurynas Biveinis (OCA)
• Status: Closed
• Category: MySQL Server: Documentation
• Severity: S3 (Non-critical)
• Version: 5.5.45
• OS: Any
• CPU Architecture: Any
• Tags: release notes

[29 Sep 2015 7:40] Laurynas Biveinis

Description:
http://dev.mysql.com/doc/relnotes/mysql/5.5/en/news-5-5-45.html

"InnoDB: On Unix-like platforms, os_file_create_simple_no_error_handling_func and os_file_create_func opened files in different modes when innodb_flush_method was set to O_DIRECT. (Bug #21113036, Bug #76627)"

But source code analysis shows that these two functions still should be opening the file in different modes in 5.5.

How to repeat:
Check http://bugs.mysql.com/bug.php?id=76627 on 5.5

Suggested fix:
If it's really fixed on 5.5, clarify how. Otherwise remove the fix mention from 5.5 RNs.

[30 Oct 2015 12:53] Laurynas Biveinis

$ git show b4daac21
commit b4daac21f52ced96c11632b83445111c0acede56
Author: Bin Su <[e-mail]>
Date:   Thu May 21 11:52:17 2015 +0800

    Bug#21113036 - MYSQL/INNODB MIX BUFFERED AND DIRECT IO
    
    As man page of open(2) suggested, we should open the same file in the same
    mode, to have better performance. For some data files, we will first call
    os_file_create_simple_no_error_handling_func() to open them, and then call
    os_file_create_func() again. We have to make sure if DIRECT IO is specified,
    these two functions should both open file with O_DIRECT.
    
    Reviewed-by: Sunny Bains <[e-mail]>
    RB: 8981