| Bug #77987 | Calling StatementImpl.cancel() doesn't kill a query when using streamed results | ||
|---|---|---|---|
| Submitted: | 7 Aug 2015 19:50 | Modified: | 2 Oct 2015 18:53 |
| Reporter: | KUNO OSPALD | Email Updates: | |
| Status: | Verified | Impact on me: | |
| Category: | Connector / J | Severity: | S3 (Non-critical) |
| Version: | 5.1.35 | OS: | Any |
| Assigned to: | Filipe Silva | CPU Architecture: | Any |
[10 Aug 2015 19:32]
Mark Matthews
This patch won't work correctly, it removes a required safety guard, which prevents you from canceling *future* statements. It's more like statementExecuting isn't getting set correctly for streaming statements?
[10 Aug 2015 23:11]
KUNO OSPALD
Thank you for looking at this bug report. Your assumption that statementExecuting is not set correctly for streaming content is correct. But I don't understand why the existing code would prevent "canceling *future* statements" without any synchronization.
[18 Aug 2015 10:06]
KUNO OSPALD
Hi Mark, Did you have a chance to look into this issue again? Kuno
[2 Oct 2015 18:53]
Filipe Silva
Hi Kuno, Thank you for this bug report. What Mark meant by "canceling *future* statements" is a consequence of the behavior observed in MySQL 5.6 and lower versions that, when you issue a KILL QUERY statement without an active running query in that connection, the next one gets killed before starting, and it doesn't event need to be issued from the same Statement instance. This doesn't happen in MySQL 5.7 though. You are right regarding statementExecuting not being set correctly for streaming statements and it should be fixed. This bug report is now verified as described.
[5 Oct 2015 16:14]
Filipe Silva
May be interested in following the related Bug#77658.
Description: When the results of a query are streamed, calling StatementImpl.cancel() will not cancel the running query ("KILL QUERY" command is not send to the server). How to repeat: Start a long running query with streaming results and call StatementImpl.cancel(). The query will not be killed. Suggested fix: --- /mysql-connector-j-5.1.35 - org/src/com/mysql/jdbc/StatementImpl.java Fri Aug 07 19:44:11 2015 +++ /mysql-connector-j-5.1.35/src/com/mysql/jdbc/StatementImpl.java Fri Aug 07 19:45:59 2015 @@ -404,10 +404,6 @@ * cancel a statement that is being executed by another thread. */ public void cancel() throws SQLException { - if (!this.statementExecuting.get()) { - return; - } - if (!this.isClosed && this.connection != null && this.connection.versionMeetsMinimum(5, 0, 0)) { Connection cancelConn = null; java.sql.Statement cancelStmt = null;