MySQL Bugs: #77647: SUSE patches we keep against 5.7 (contribution)

Bug #77647	SUSE patches we keep against 5.7 (contribution)
Submitted:	8 Jul 2015 0:31	Modified:	1 Oct 2018 19:44
Reporter:	OCA Admin (OCA)	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: Packaging	Severity:	S3 (Non-critical)
Version:		OS:	Any
Assigned to:	Tor Didriksen	CPU Architecture:	Any

Description:
This bug tracks a contribution by Tomáš Chvátal (Github user: scarabeusiv) as described in http://github.com/mysql/mysql-server/pull/16

How to repeat:
See description

Suggested fix:
See contribution code attached

Contribution submitted via Github - SUSE patches we keep against 5.7 (*) Contribution by Tomáš Chvátal (Github scarabeusiv, mysql-server/pull/16#issuecomment-119315804): "I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."

Contribution: git_patch_38524571.txt (text/plain), 10.47 KiB.

Hello!

Thank you for the report and contribution.

Thanks,
Umesh

Thanks for the contribution,
I will have a look at each individual patch.

Posted by developer:
 
Status on the contribution:

[PATCH 1/5] FEATURE Adds group option
 Touching mysqld_safe and mysql_install_db which is
 removed or will be removed.
 Server itself (mysqld) don't have group concept any way.

 Contribution not accepted.

[PATCH 2/5] Fix linking options
 This is bug https://bugs.mysql.com/bug.php?id=39175
 Accepted, but not done yet.

[PATCH 3/5] Rename srv_buf_size variable bug#70047
 Fixed by ae3c04a3a8b3a91c903e9dba5b5e9374de134d79

 commit ae3c04a3a8b3a91c903e9dba5b5e9374de134d79
 Author: Satya Bodapati <satya.bodapati@oracle.com>
 Date:   Fri Aug 23 18:03:27 2013 +0530
    BUG#17316314 - SRV_BUF_SIZE NOT DECLARED
    Temporary fix. Disabling FALLOC_FL_PUNCH_HOLE for now

 and then fully fixed by:

 commit ebbb67370e15895ecbdf992af887fd818a476c55
 Author: Sunny Bains <Sunny.Bains@oracle.com>
 Date:   Wed Mar 4 13:58:59 2015 +1100
    WL#7696 - Backport code from mysql-trunk to mysql-5.7

[PATCH 4/5] Keep datadir across multiple calls
 Accepted as:
 commit 93d05b877ecbd5e453b55349e7fdaf20dfd71463
 Author: Tor Didriksen <tor.didriksen@oracle.com>
 Date:   Tue Oct 13 07:33:32 2015 +0200

  Bug#21387880 SUSE PATCHES WE KEEP AGAINST 5.7 (CONTRIBUTION)
     [PATCH 4/5] Keep datadir across multiple calls mysql_upgrade script asks
     for datadir multiple times during update but at some point
     privileges gets updated and if --skip-grant-tables was used (like
     in SUSE init scripts), datadir is no longer queryable. So we
     cache the value.
    This patch is based on a contribution from  Michal Hrusecky

[PATCH 5/5] Use CMAKE STATIC declaration where needed
 Accepted as:
 commit 4f8c29f6158022fa846d019fd27742aae30ea4e4
 Author: Tor Didriksen <tor.didriksen@oracle.com>
 Date:   Thu Oct 15 15:39:55 2015 +0200

    Bug#21387880 SUSE PATCHES WE KEEP AGAINST 5.7 (CONTRIBUTION)
    [PATCH 5/5] Use CMAKE STATIC declaration where needed
    This prevents broken build with -DBUILD_SHARED_LIBS=1 on cmake command line

Posted by developer:
 
Tor Didriksen: seems like all 5 issues are resolved

Posted by developer:
 
Fixed in 5.7.10.

Configuring with -DBUILD_SHARED_LIBS=1 resulted in a build error.
Thanks to SuSE for the contribution.