Bug #77646 SUSE patches we keep against 5.6 (contribution)

• Submitted: 8 Jul 2015 0:27
• Modified: 8 Jul 2015 4:17
• Reporter: OCA Admin (OCA)
• Status: Verified
• Category: MySQL Server: Packaging
• Severity: S3 (Non-critical)
• OS: Any
• Assigned to: Tor Didriksen
• CPU Architecture: Any

[8 Jul 2015 0:27] OCA Admin

Description:
This bug tracks a contribution by Tomáš Chvátal (Github user: scarabeusiv) as described in http://github.com/mysql/mysql-server/pull/17

How to repeat:
See description

Suggested fix:
See contribution code attached

[8 Jul 2015 0:27] OCA Admin

Contribution submitted via Github - SUSE patches we keep against 5.6 
(*) Contribution by Tomáš Chvátal (Github scarabeusiv, mysql-server/pull/17#issuecomment-119315784): "I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it."

Contribution: git_patch_38525115.txt (text/plain), 15.46 KiB.

[8 Jul 2015 4:17] MySQL Verification Team

Hello!

Thank you for the report and contribution.

Thanks,
Umesh

[17 Jul 2015 11:30] Tor Didriksen

Thanks for the contribution,
I will have a look at each individual patch.

[14 Oct 2016 12:02] Ståle Deraas

Posted by developer:
 
As contribution status, I am setting this to ACCEPT, as some issues are fixed, though with other fixes.

This is an update on the status of the series of patches contributed:

[PATCH 1/8] Use CMAKE STATIC declaration where needed
 Not included in 5.6, but accepted in 5.7.

[PATCH 2/8] Fix heap overflow vulnerability in regex library
 Seems to be obsolete by:

 commit ca1f80e778d81e9c5a5215416c9deef448947bd6
 Author: Tatiana Azundris Nuernberg <[e-mail]>
 Date:   Mon May 18 08:09:02 2015 +0100

    Bug#20642505: HENRY SPENCER REGULAR EXPRESSIONS (REGEX) LIBRARY
    The MySQL server uses Henry Spencer's library for regular
    expressions to support the REGEXP/RLIKE string operator.
    This changeset adapts a recent fix from the upstream for
    better 32-bit compatiblity. (Note that we cannot simply use
    the current upstream version as a drop-in replacement
    for the version used by the server as the latter has
    been extended to understand MySQL charsets etc.)

[PATCH 3/8] Rename srv_buf_size variable bug#70047
 Made obsolete by:

 commit ae3c04a3a8b3a91c903e9dba5b5e9374de134d79
 Author: Satya Bodapati <[e-mail]>
 Date:   Fri Aug 23 18:03:27 2013 +0530

    BUG#17316314 - SRV_BUF_SIZE NOT DECLARED
    Temporary fix. Disabling FALLOC_FL_PUNCH_HOLE for now

 Note: MySQL 5.7 have a better fix.

[PATCH 4/8] FEATURE Keep datadir across multiple calls
 Not included in 5.6 but accepted in MySQL 5.7

[PATCH 5/8] Fix linking options
 Still evaluating for 5.6

[PATCH 6/8] Fix possible buffer overflow
 Not included in MySQL 5.6.

 Note: fixed in MySQL 5.7 by:
  commit 6a6286ccfa18d424919eebc8cbfbabcc9555d968
  Author: Thayumanavar <[e-mail]>
  Date:   Wed Sep 4 10:50:02 2013 +0530

    BUG#17204851 - POSSIBLE BUFFER OVERFLOW IN MYSYS/MF_LOADPATH.C
    DESCRIPTION AND FIX:
    The function my_load_path (in mysys/mf_loadpath.c), when
    it appends current working directory with supplied path
    name via strncat, it passes FN_REFLEN-1 as the
    buffer size avaliable. But the buffer space is already
    filled with current working directory path , so the actual
    avaliable space for the string to be appended is
    FN_REFLEN-(length of buffer already filled)-1. The patch
    fixes this and in addition avoids unneccessary strnmov/
    strnxmov in cases where the supplied pathname need
    not be modified.

[PATCH 7/8] FEATURE Adds group option
 Not accepted in any MySQL version.

[PATCH 8/8] Make hotcopy to ignores log tables
 Not included as mysqlhotcopy.sh is removed in MySQL 5.7+