Bug #77229 Update echo.c (contribution)
Submitted: 2 Jun 2015 15:53 Modified: 3 Jun 2015 16:52
Reporter: OCA Admin (OCA) Email Updates:
Status: Verified Impact on me:
None 
Category:MySQL Server: Command-line Clients Severity:S3 (Non-critical)
Version: OS:Any
Assigned to: CPU Architecture:Any

[2 Jun 2015 15:53] OCA Admin 
Description:
This bug tracks a contribution by Victor Neville (Github user: master-vic) as described in http://github.com/mysql/mysql-server/pull/8

How to repeat:
See description

Suggested fix:
See contribution code attached
[2 Jun 2015 15:53] OCA Admin 
Contribution submitted via Github - Update echo.c 
(*) Contribution by Victor Neville (Github master-vic, mysql-server/pull/8#issuecomment-107987502): Hi,
I confirm the code being submitted is offered under the terms of the OCA, and that I am authorized to contribute it.
Thanks

Contribution: git_patch_35649495.txt (text/plain), 1.56 KiB.
[3 Jun 2015 16:52] MySQL Verification Team 
This is a small, but welcome contribution to our command-line client programs. This program does not have much of the significance, but a patch is clear and purposeful. The program itself is meant for the usage on Windows only and has not been changed since 2007. 

Verified.

It would be nice if someone would write a program in the Windows new PowerShell.
[4 Jun 2015 15:58] Georgi Kodinov 
Thank you for your contribution. I am afraid it needs more work as it fails to cover some edge cases.
Also I'm currently not aware of any performance issues stemming from how the utility is coded.
But I'm willing to reconsider if you provide enough evidence that the change you're proposing is actually contributing a speed up in some identifiable workflow.
[8 Jun 2015 6:05] Victor Neville 
Performance Analysis

Attachment: performance_analysis.zip (application/zip, text), 549.07 KiB.
[8 Jun 2015 6:06] Victor Neville 
I tested both versions of the echo and I compared the results with Intel VTune Amplifier 2015 which is a great tool for software performance analysis. The test has been made on my Linux system by calling the echo with 10 arguments as follow: ./echo "a0" "a1" "a2" "a3" "a4" "a5" "a6" "a7" "a8" "a9"
The results show that the proposed version uses 2 times less CPU Time compared to the actual version.