Bug #75385 large dat apassed by parameters
Submitted: 1 Jan 2015 12:20 Modified: 17 Dec 2018 19:21
Reporter: Joshua Rogers Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Compiling Severity:S3 (Non-critical)
Version:5.7.6, 5.6.22 OS:Any
Assigned to: CPU Architecture:Any

[1 Jan 2015 12:20] Joshua Rogers 
Description:
they should be passed by reference.

refer to the screenshot here: https://internot.info/docs/Screenshot%20from%202015-01-01%2023:15:13.png 
to all locations/functions.

How to repeat:
.

Suggested fix:
.
[2 Jan 2015 10:05] MySQL Verification Team 
Hello Joshua Rogers,

Thank you for the report.

Thanks,
Umesh
[20 Nov 2018 13:29] Dyre Tjeldvoll 
Posted by developer:
 
Primary culprit appears to be the ErrConvString class which contains a char buffer for the message to convert, and which is passed by value in a number of places. This should probably be changed to const&, but his class is missing const specifiers on some of its methods, so this will need to be addressed before it can be passed by const&.

Going forward we can check for this type of problem using the clang-tidy chick performance-unnecessary-value-param
[17 Dec 2018 19:21] Paul DuBois 
Posted by developer:
 
Fixed in 8.0.15.

Code cleanup. No changelog entry needed.