Bug #74453 Remove HAVE_ATOMIC_BUILTINS from InnoDB source code

• Submitted: 20 Oct 2014 12:13
• Modified: 22 Oct 2014 12:55
• Reporter: Marko Mäkelä
• Status: Closed
• Category: MySQL Server: InnoDB storage engine
• Severity: S3 (Non-critical)
• Version: 5.7.5
• OS: Any
• CPU Architecture: Any

[20 Oct 2014 12:13] Marko Mäkelä

Description:
Since a recent change in MySQL 5.7.5
WL#7655 Remove MY_ATOMIC_MODE_RWLOCKS
the MySQL build depends on atomic memory access primitives being present on the target platform.

When this change was implemented, similar code in InnoDB was not removed.

How to repeat:
Search the InnoDB code base for HAVE_ATOMIC_BUILTINS.

Suggested fix:
Remove the code, and assume that atomic builtins are available.

Remove "have_atomic_builtins" from SHOW VARIABLES output.

[22 Oct 2014 12:55] Daniel Price

Posted by developer:
 
Fixed as of the upcoming 5.7.6 release, and here's the changelog entry:

As of MySQL 5.7.5, MySQL builds depend on atomic memory access primitives
being present on the target platform. To simplify the code,
"HAVE_ATOMIC_BUILTINS" are removed from the "InnoDB" source in MySQL
5.7.6. "InnoDB" now depends on Microsoft atomics on Windows, and on
GCC-style atomics on other platforms.