MySQL Bugs: #74156: Simplify create/drop temporary table

Bug #74156	Simplify create/drop temporary table
Submitted:	30 Sep 2014 14:33	Modified:	2 Oct 2014 17:05
Reporter:	Marko Mäkelä	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: InnoDB storage engine	Severity:	S3 (Non-critical)
Version:	5.7.5	OS:	Any
Assigned to:		CPU Architecture:	Any

View
Add Comment
Files
Developer
Edit Submission
View Progress Log
Contributions

Description:
There are some repeated conditions in ha_innobase::create() and ha_innobase::delete_table() when creating or dropping temporary tables. The logic could be streamlined a little, removing some conditional branches.

How to repeat:
See Description.

Suggested fix:
Remove redundant conditions, and partly replace them with debug assertions.

Posted by developer:
 
Fixed as of the upcoming 5.7.6 release, and here's the changelog entry:

Removed redundant conditional branching and a redundant a check for
"srv_read_only_mode" from "ha_innobase::create()". Removed redundant
conditional branching and an unused local variable,
"is_intrinsic_temp_table", from "ha_innobase::delete_table()".