MySQL Bugs: #73740: Clean up tests that kill or restart the server

Bug #73740	Clean up tests that kill or restart the server
Submitted:	27 Aug 2014 10:12	Modified:	28 Aug 2014 14:18
Reporter:	Marko Mäkelä	Email Updates:
Status:	Closed	Impact on me:	None
Category:	MySQL Server: InnoDB storage engine	Severity:	S3 (Non-critical)
Version:	5.7.5	OS:	Any
Assigned to:		CPU Architecture:	Any

Description:
There are a number of tests that are killing or restarting the server.
We should try to use common infrastructure for these.

SET DEBUG='d,crash_commit_before';
should not be used for just killing the server. A normal kill will run on a non-debug binary as well.

Valgrind should not be disabled when the server is being killed by the test script.
There still seems to be a problem with DBUG_SUICIDE, so we will have to disable Valgrind when the server is killed by test instrumentation.

How to repeat:
Watch the test failures on PB2.
One of the latest was innodb.log_file_size, which got a different error when the server was killed before a statement was submitted.

Suggested fix:
Introduce a few helper files.

include/kill_mysqld.inc
include/kill_and_restart_mysqld.inc

Introduce $restart_parameters for the above, and

include/start_mysqld.inc
include/restart_mysqld.inc

Use these scripts as much as possible, instead of "rolling your own" restart.

Test related changes. No changelog entry required.

Posted by developer:
 
Closing again. Test suite- changes. No changelog entry required.