Bug #73623 Please clean up the innodb_gis test suite
Submitted: 18 Aug 2014 10:07 Modified: 17 Oct 2014 18:01
Reporter: Marko Mäkelä Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: InnoDB storage engine Severity:S3 (Non-critical)
Version:5.7.5 OS:Any
Assigned to: CPU Architecture:Any

[18 Aug 2014 10:07] Marko Mäkelä 
Description:
Some tests in the recently added innodb_gis suite are being skipped on certain test platforms seemingly for no reason.
The test file names are unnecessarily long and redundant. If the suite name is innodb_gis, why do all test files start with innodb_gis_? Also the rtree_ or spatial_ in test file names are somewhat redundant.

How to repeat:
Read the code.

Suggested fix:
Rename the files to simpler names, and remove some abbreviations while doing that.
Remove unnecessary have_debug.inc and not_embedded.inc. For example, the following does pass after the unnecessary skipping is removed:

mtr --embedded innodb_gis.innodb_gis_rtree_multi_pk
[29 Aug 2014 7:38] Marko Mäkelä 
Posted by developer:
 
Some of the original request was addressed by

Bug#19514950 CLEAN UP TESTS THAT KILL OR RESTART THE SERVER
MySQL Bug: 73740

I will fix the rest by removing redundancy from all test file names in the InnoDB suites.
[17 Oct 2014 5:38] Marko Mäkelä 
Posted by developer:
 
Some test names in the innodb_* suites were renamed. The test names in --suite=innodb were left as is, because many of them occur in PB2 reports, and the tracking is based on names.
[17 Oct 2014 18:01] Daniel Price 
Posted by developer:
 
Test related fix. No changelog entry required.