Bug #73470 mysqlbinlog stop-never-slave-server-id max value is 65536
Submitted: 5 Aug 2014 9:13 Modified: 5 Aug 2014 19:16
Reporter: rj03hou rj03hou Email Updates:
Status: Closed Impact on me:
None 
Category:MySQL Server: Command-line Clients Severity:S3 (Non-critical)
Version:5.6 OS:Any
Assigned to: CPU Architecture:Any

[5 Aug 2014 9:13] rj03hou rj03hou
Description:
mysqlbinlog stop-never-slave-server-id max value is 65536

according to the document of <Replication and Binary Logging Options and Variables>, the max value of server-id is 4294967295, why mysqlbinlog stop-never-slave-server-id is 65536, why the rule is different?

How to repeat:
just use this option stop-never-slave-server-id to bigger than 65536:
Warning: option 'stop-never-slave-server-id': unsigned value 64015003 adjusted to 65535

Suggested fix:
modify client/mysqlbinlog.cc, change the max value to 4294967295。
 {"stop-never-slave-server-id", OPT_WAIT_SERVER_ID,
   "The slave server ID used for stop-never",
   &stop_never_server_id, &stop_never_server_id, 0,
   GET_UINT, REQUIRED_ARG, 65535, 1, 65535, 0, 0, 0},
[5 Aug 2014 10:26] MySQL Verification Team
Hello!

Thank you for the report.
I cannot repeat this on latest builds.
Could you please check with the latest build and inform us if you are still seeing this issue at your end?

// 5.6.20
mysql-advanced-5.6.20]$ bin/mysqlbinlog --read-from-remote-server -hlocalhost -uroot -p  master-bin.000003 --stop-never-slave-server-id=4294967296
Enter password:
Warning: option 'stop-never-slave-server-id': signed value 4294967296 adjusted to 4294967295

^^ >4294967295 and adjusted to 4294967295 

[ushastry@cluster-repo mysql-advanced-5.6.20]$ bin/mysqlbinlog --read-from-remote-server -hlocalhost -uroot -p  master-bin.000003 --stop-never-slave-server-id=4294967295
Enter password:
/*!50530 SET @@SESSION.PSEUDO_SLAVE_MODE=1*/;
/*!40019 SET @@session.max_insert_delayed_threads=0*/;
/*!50003 SET @OLD_COMPLETION_TYPE=@@COMPLETION_TYPE,COMPLETION_TYPE=0*/;
DELIMITER /*!*/;

^^ 4294967295 is accepted and no warnings 

Looking at the code, I can see now that it is fixed in 5.6.20
// 5.6.15

/home/ushastry/mybuilds/mysql-5.6.15/client/mysqlbinlog.cc:

 1531    {"stop-never-slave-server-id", OPT_WAIT_SERVER_ID,
 1532:    "The slave server ID used for stop-never",
 1533     &stop_never_server_id, &stop_never_server_id, 0,
 1534     GET_UINT, REQUIRED_ARG, 65535, 1, 65535, 0, 0, 0},

^^ 65535

// 5.6.20

  {"stop-never-slave-server-id", OPT_WAIT_SERVER_ID,
   "The slave server_id used for --read-from-remote-server --stop-never.",
   &stop_never_slave_server_id, &stop_never_slave_server_id, 0,
   GET_LL, REQUIRED_ARG, -1, -1, 0xFFFFFFFFLL, 0, 0, 0},

^^ 4294967295

Thanks,
Umesh
[5 Aug 2014 14:28] Hartmut Holzgraefe
status should be Closed, not Need Feedback, as this was fixed in 5.6.20 and found to be true in previous versions?