Bug #73408 m_cond_preempt is not destroyed when debug enabled

• Submitted: 28 Jul 2014 2:07
• Modified: 28 Jul 2014 6:22
• Reporter: zhai weixiang (OCA)
• Status: Verified
• Category: MySQL Server: Replication
• Severity: S3 (Non-critical)
• Version: 5.7.4
• OS: Any
• CPU Architecture: Any

[28 Jul 2014 2:07] zhai weixiang

Description:
when debug enabled, m_cond_preempt is inited but not destroyed. just check the code.

hailanlantekiMacBook-Air:mysql-5.7.4-m14 hailanlan$ grep 'm_cond_preempt' -R * --color
sql/binlog.cc:      mysql_cond_signal(&m_cond_preempt);
sql/binlog.cc:    mysql_cond_wait(&m_cond_preempt, &m_lock_done);
sql/binlog.h:    mysql_cond_init(key_COND_done, &m_cond_preempt, NULL);
sql/binlog.h:  mysql_cond_t m_cond_preempt;

How to repeat:
read the code

Suggested fix:
correct it.

[28 Jul 2014 6:22] MySQL Verification Team

Hello Zhai Weixiang,

Thank you for the report.
Verifying based on the code inspection.

Thanks,
Umesh

[28 Jul 2014 6:24] MySQL Verification Team

// 5.7.4

mysql-5.7.4]$  grep -n 'm_cond_preempt' -R * --color
sql/binlog.h:141:    mysql_cond_init(key_COND_done, &m_cond_preempt, NULL);
sql/binlog.h:247:  mysql_cond_t m_cond_preempt;
sql/binlog.cc:1505:      mysql_cond_signal(&m_cond_preempt);
sql/binlog.cc:1543:    mysql_cond_wait(&m_cond_preempt, &m_lock_done);