Bug #72940 suite/binlog/t/binlog_killed.test forgets to disconnect con1 and con2

• Submitted: 10 Jun 2014 15:11
• Modified: 23 Jun 2014 13:19
• Reporter: Matthias Leich
• Status: Closed
• Category: Tests: Replication
• Severity: S3 (Non-critical)
• Version: 5.7.5
• OS: Any
• CPU Architecture: Any

[10 Jun 2014 15:11] Matthias Leich

Description:
The test suite/binlog/t/binlog_killed.test makes the connections
con1 and con2 but forgets to disconnect them + wait till that
operation is finished at test end.
This mistake has the potential to harm subsequent tests in
case these tests depend on the content of the processlist.

How to repeat:
Either
- look into the code of suite/binlog/t/binlog_killed.test
  There is no disconnect + wait_until_disconnected.inc
  within the test.
or
- check the test by some tool which is capable to generate
  some high load on the testing box.

Suggested fix:
#
# common cleanup
#
connection con1;
disconnect con1;
--source include/wait_until_disconnected.inc
connection con2;
disconnect con2;
--source include/wait_until_disconnected.inc
connection default;

drop table t1,t2,t3;

--echo end of the tests

[10 Jun 2014 15:16] Matthias Leich

Posted by developer:
 
I have found on my box a crowd MySQL releases and in
all cases BINLOG_KILLED.TEST lacked the disconnect.
The oldest release was a MySQL 5.1 Year 2012.

[23 Jun 2014 13:19] Jon Stephens

Fixed in 5.5.39, 5.6.20, 5.7.5. Affects testing only; no changelog entry needed; closed.

Thank you for your bug report. This issue has been committed to our source repository of that product and will be incorporated into the next release.

If necessary, you can access the source repository and build the latest available version, including the bug fix. More information about accessing the source trees is available at

    http://dev.mysql.com/doc/en/installing-source.html